Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simple list of last added prices #26

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Dec 18, 2023

What

  • New nav drawer item "Last prices"
  • show most recent prices first
  • simple card with price / product / location details (dedicated component)

Todo (in futur PRs)

  • currency : avoid hardcoded "€"
  • quantity : display products with "L"
  • bigger image : 2 columns instead of "card"
  • search, reorder, filter

Questions

  • what to display if information missing ?

Screenshot

image

@raphodn raphodn self-assigned this Dec 18, 2023
@raphodn raphodn force-pushed the raphodn/dashboard-contributions branch from 41f5983 to 2dd9534 Compare December 18, 2023 15:36
@raphodn raphodn marked this pull request as ready for review December 19, 2023 13:50
<v-card-title v-if="price.product">{{ price.product.product_name }}</v-card-title>
<v-card-title v-if="!price.product">{{ price.product_code }}</v-card-title>

<v-card-subtitle v-if="price.product">{{ price.product.product_quantity }} · {{ price.product.brands }}</v-card-subtitle>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the field product.brands is currently being added in the backend : openfoodfacts/open-prices#93

src/components/PriceCard.vue Outdated Show resolved Hide resolved
@raphodn raphodn force-pushed the raphodn/dashboard-contributions branch from 0a19fb5 to a22eaeb Compare December 20, 2023 11:46
@raphodn raphodn changed the title Simple list of last added prices feat: simple list of last added prices Dec 20, 2023
@raphodn raphodn merged commit 101ed5e into master Dec 20, 2023
@raphodn raphodn deleted the raphodn/dashboard-contributions branch December 20, 2023 11:50
@raphodn raphodn linked an issue Dec 20, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page with recently added prices
1 participant