Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(price card): improve look & feel #77

Merged
merged 5 commits into from
Dec 29, 2023
Merged

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Dec 27, 2023

What

Price card v2 (v1 in #26)

Changes :

Screenshot

image

@raphodn raphodn self-assigned this Dec 28, 2023
@raphodn raphodn requested a review from raphael0202 December 28, 2023 10:15
@raphodn raphodn marked this pull request as ready for review December 28, 2023 10:17
@raphodn raphodn force-pushed the raphodn/price-card-v2 branch from 31d60f4 to 56f8975 Compare December 28, 2023 10:26
Copy link
Contributor

@raphael0202 raphael0202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice revamp 👍

@teolemon
Copy link
Member

I got some feedback that the store indication could be ambiguous. We already have two Auchan in Grenoble. We'll need to see if we want to act on this (perhaps with hash-based colors ?).

@raphodn
Copy link
Member Author

raphodn commented Dec 29, 2023

I got some feedback that the store indication could be ambiguous. We already have two Auchan in Grenoble. We'll need to see if we want to act on this (perhaps with hash-based colors ?).

Yes i was thinking of :

  • adding a 🇫🇷 flag instead of the 📍 to show the location
  • adding the road info, but : it could make the text quite long ; we don't store it yet in the backend..

image

@raphodn raphodn force-pushed the raphodn/price-card-v2 branch 2 times, most recently from fbdde61 to 3adac17 Compare December 29, 2023 10:56
@raphodn raphodn merged commit 3151439 into master Dec 29, 2023
@raphodn raphodn deleted the raphodn/price-card-v2 branch December 29, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants