Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlocalized string on the pro platform #8194

Closed
2 tasks
teolemon opened this issue Mar 13, 2023 · 3 comments · Fixed by #8203
Closed
2 tasks

Unlocalized string on the pro platform #8194

teolemon opened this issue Mar 13, 2023 · 3 comments · Fixed by #8203
Assignees
@jnsereko
Labels
🐛 bug This is a bug, not a feature request. good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Outreachy Good tasks for Outreachy applicants. See #productopener on our Slack https://slack.openfoodfacts.org 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. ⏲️ 5 minute fix

Comments

@teolemon
Copy link
Member

What

Part of
@teolemon teolemon added ✅ Task 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers 🐛 bug This is a bug, not a feature request. ⏲️ 5 minute fix and removed ✅ Task labels Mar 13, 2023
@yuktea yuktea assigned yuktea and unassigned yuktea Mar 14, 2023
@yuktea yuktea added good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Outreachy Good tasks for Outreachy applicants. See #productopener on our Slack https://slack.openfoodfacts.org Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Mar 14, 2023
@yuktea
Copy link
Contributor

yuktea commented Mar 14, 2023

This should be straightforward. We'll need to assign an id (some identifier) for the string and pass the ID through the lang() function + add the original string with it's corresponding id to the language files.

added the good-first-issue tag 👍

@jnsereko
Copy link
Contributor

jnsereko commented Mar 14, 2023 •
edited
Loading

hey @yuktea
this is really an awesome issue. I wish to push a fix for this

Thank you for the good description, its really helpful

@yuktea yuktea assigned yuktea and jnsereko and unassigned yuktea Mar 14, 2023
jnsereko added a commit to jnsereko/openfoodfacts-server that referenced this issue Mar 14, 2023
@jnsereko
fix: Unlocalized string on the pro platform openfoodfacts#8194
89bd98a
@jnsereko
Copy link
Contributor

PR: #8203

jnsereko added a commit to jnsereko/openfoodfacts-server that referenced this issue Mar 14, 2023
@jnsereko
fix: Unlocalized string on the pro platform openfoodfacts#8194
48061c9
@yuktea yuktea mentioned this issue Mar 15, 2023
Merged
stephanegigandet pushed a commit that referenced this issue Mar 16, 2023
@jnsereko
fix: Unlocalized string on the pro platform #8194 (#8203)
48a7f73
@github-project-automation github-project-automation bot moved this from To do to Done in 🏭 Producers Platform Mar 16, 2023
@openfoodfacts-bot openfoodfacts-bot mentioned this issue Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnsereko jnsereko

Labels
🐛 bug This is a bug, not a feature request. good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Outreachy Good tasks for Outreachy applicants. See #productopener on our Slack https://slack.openfoodfacts.org 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. ⏲️ 5 minute fix
Projects
🏭 Producers Platform
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Unlocalized string on the pro platform #8194 jnsereko/openfoodfacts-server
3 participants
@teolemon @jnsereko @yuktea