Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unlocalized string on the pro platform #8194 #8203

Merged
merged 2 commits into from
Mar 16, 2023
Merged

fix: Unlocalized string on the pro platform #8194 #8203

merged 2 commits into from
Mar 16, 2023

Conversation

jnsereko
Copy link
Contributor

@jnsereko jnsereko commented Mar 14, 2023 •
edited by yuktea
Loading

What

Unlocalized string on the pro platform

just referenced the required message by its locale message ID instead of hard coding it.
cc @yuktea @teolemon

Screenshot

Related issue(s) and discussion

@jnsereko jnsereko requested a review from a team as a code owner March 14, 2023 16:07
@github-actions github-actions bot added ✏️ Editing Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Mar 14, 2023
@jnsereko jnsereko mentioned this pull request Mar 14, 2023
Closed
2 tasks
@yuktea
Copy link
Contributor

yuktea commented Mar 14, 2023

Looks like you forgot staging changes to the language files where you put that string id.

@teolemon teolemon added Product Page 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers labels Mar 15, 2023
@teolemon
Copy link
Member

Note that you only need to add it to common.pot and en.po. Crowdin will propagate the rest

@jnsereko
Copy link
Contributor Author

jnsereko commented Mar 15, 2023 •
edited
Loading

hey @yuktea @teolemon I didn't get an email notification about the replies about this early enough, am sorry!

the string_ID. correct_the_following_errors is already in existence. I first checked to avoid duplication.

ref

@github-actions github-actions bot removed the 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers label Mar 15, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

stephanegigandet
stephanegigandet approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 48a7f73 into openfoodfacts:main Mar 16, 2023
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@jnsereko jnsereko

Labels
✏️ Editing Product Page Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unlocalized string on the pro platform
4 participants
@jnsereko @yuktea @teolemon @stephanegigandet