Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove various errors that are polluting the Test suite outputs #9655

Closed
teolemon opened this issue Jan 15, 2024 · 0 comments · Fixed by #11191
Closed

Remove various errors that are polluting the Test suite outputs #9655

teolemon opened this issue Jan 15, 2024 · 0 comments · Fixed by #11191
Labels
CI Continuous integration 👩‍💻 DevOps

Comments

@teolemon
Copy link
Member

teolemon commented Jan 15, 2024

What

Error 1

  • https://github.com/openfoodfacts/openfoodfacts-server/actions/runs/7462755789/job/20306470532?pr=9288#step:4:3088
  • error: error parsing xml file with XML::Rules {error => "\nno element found at line 1, column 83, byte 83 at /opt/perl/local/lib/perl5/XML/Rules.pm line 745.\n",file => "tests/unit//inputs/import_convert_carrefour_france/13003_3270190006787_valNut.xml"}
    Use of uninitialized value in addition (+) at /opt/product-opener/lib/ProductOpener/ImportConvertCarrefourFrance.pm line 399.
    File tests/unit//inputs/import_convert_carrefour_france/13766_8431876196009_text.xml - Code: 8431876196009
    Reading file tests/unit//inputs/import_convert_carrefour_france/13766_8431876196009_text.xml
    Use of uninitialized value in concatenation (.) or string at /opt/product-opener/lib/ProductOpener/ImportConvertCarrefourFrance.pm line 160.

Error 2

https://github.com/openfoodfacts/openfoodfacts-server/actions/runs/7462755789/job/20306470532?pr=9288#step:4:15260
warning: GS1Parser error {error => bless( {message => "No GS1 DL keys found in path info",previous_exception => ""}, 'GS1::SyntaxEngine::FFI::EncoderParameterException' )}
warning: GS1Parser error {error => bless( {message => "No GS1 DL keys found in path info",previous_exception => ""}, 'GS1::SyntaxEngine::FFI::EncoderParameterException' )}
tests/unit/products.t ......................... ok

Error 3

https://github.com/openfoodfacts/openfoodfacts-server/actions/runs/7462755789/job/20306470532?pr=9288#step:4:560
Name "FFI::Platypus::keep" used only once: possible typo at /usr/lib/x86_64-linux-gnu/perl-base/XSLoader.pm line 111.
error: ecoscore origin does not exist in taxonomy {origin => "IW",origin_id => "en:IW"}
error: ecoscore origin does not exist in taxonomy {origin => "SW",origin_id => "en:SW"}
error: ecoscore origin does not exist in taxonomy {origin => "US-AL",origin_id => "en:US-AL"}
error: ecoscore origin does not exist in taxonomy {origin => "US-GA",origin_id => "en:US-GA"}
error: ecoscore origin does not exist in taxonomy {origin => "US-LA",origin_id => "en:US-LA"}
error: ecoscore origin does not exist in taxonomy {origin => "US-MS",origin_id => "en:US-MS"}
error: ecoscore origin does not exist in taxonomy {origin => "US-SC",origin_id => "en:US-SC"}
error: ecoscore origin does not exist in taxonomy {origin => "US-TX",origin_id => "en:US-TX"}
error: ecoscore origin does not exist in taxonomy {origin => "WO",origin_id => "en:WO"}
error: ecoscore origin does not exist in taxonomy {origin => "Eaux internationales",origin_id => "fr:Eaux internationales"}
error: ecoscore origin does not exist in taxonomy {origin => "S\x{e3}o Tom\x{e9} e Pr\x{ed}ncipe",origin_id => "fr:S\x{e3}o Tom\x{e9} e Pr\x{ed}ncipe"}
error: ecoscore origin does not exist in taxonomy {origin => "Territoires fran\x{e7}ais du Sud",origin_id => "fr:Territoires fran\x{e7}ais du Sud"}
Use of uninitialized value $_[0] in substitution (s///) at tests/unit/attributes.t line 221.

@teolemon teolemon added 🐛 bug This is a bug, not a feature request. CI Continuous integration labels Jan 24, 2024
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
@teolemon teolemon changed the title Various errors are polluting the Test suite Remove various errors that are polluting the Test suite outputs Oct 18, 2024
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Jan 6, 2025
stephanegigandet pushed a commit that referenced this issue Jan 6, 2025
### What

```
Error 1

    https://github.com/openfoodfacts/openfoodfacts-server/actions/runs/7462755789/job/20306470532?pr=9288#step:4:3088
    error: error parsing xml file with XML::Rules {error => "\nno element found at line 1, column 83, byte 83 at /opt/perl/local/lib/perl5/XML/Rules.pm line 745.\n",file => "tests/unit//inputs/import_convert_carrefour_france/13003_3270190006787_valNut.xml"}
    Use of uninitialized value in addition (+) at /opt/product-opener/lib/ProductOpener/ImportConvertCarrefourFrance.pm line 399.
    File tests/unit//inputs/import_convert_carrefour_france/13766_8431876196009_text.xml - Code: 8431876196009
    Reading file tests/unit//inputs/import_convert_carrefour_france/13766_8431876196009_text.xml
    Use of uninitialized value in concatenation (.) or string at /opt/product-opener/lib/ProductOpener/ImportConvertCarrefourFrance.pm line 160.
```

### Related issue(s) and discussion
- Related to #9655

---------

Co-authored-by: Open Food Facts Bot <contact@openfoodfacts.org>
stephanegigandet pushed a commit that referenced this issue Jan 8, 2025
### What

```
Error 2

https://github.com/openfoodfacts/openfoodfacts-server/actions/runs/7462755789/job/20306470532?pr=9288#step:4:15260
warning: GS1Parser error {error => bless( {message => "No GS1 DL keys found in path info",previous_exception => ""}, 'GS1::SyntaxEngine::FFI::EncoderParameterException' )}
warning: GS1Parser error {error => bless( {message => "No GS1 DL keys found in path info",previous_exception => ""}, 'GS1::SyntaxEngine::FFI::EncoderParameterException' )}
tests/unit/products.t ......................... ok
```
I commented this warning. It can be used for future devs. 

However, there were additional warnings in the code because is()
expected a single comparison and not an array.
After fixing this, it showed that some tests were not passing. I fixed
them all (see reworks in Products.pm) but could be good if someone with
GS1 knowledge could review it.

Ping @hangy because I noticed that you worked on this part of the code
and GS1::SyntaxEngine::FFI::GS1Encoder

### Related issue(s) and discussion
- Related to #9655

---------

Co-authored-by: Open Food Facts Bot <contact@openfoodfacts.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration 👩‍💻 DevOps
Projects
Development

Successfully merging a pull request may close this issue.

1 participant