Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: environmental_score #11191

Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix: environmental_score #11191

merged 2 commits into from
Jan 6, 2025

Conversation

benbenben2
Copy link
Collaborator

What

Error 3

https://github.com/openfoodfacts/openfoodfacts-server/actions/runs/7462755789/job/20306470532?pr=9288#step:4:560
Name "FFI::Platypus::keep" used only once: possible typo at /usr/lib/x86_64-linux-gnu/perl-base/XSLoader.pm line 111.
error: ecoscore origin does not exist in taxonomy {origin => "IW",origin_id => "en:IW"}
error: ecoscore origin does not exist in taxonomy {origin => "SW",origin_id => "en:SW"}
error: ecoscore origin does not exist in taxonomy {origin => "US-AL",origin_id => "en:US-AL"}
error: ecoscore origin does not exist in taxonomy {origin => "US-GA",origin_id => "en:US-GA"}
error: ecoscore origin does not exist in taxonomy {origin => "US-LA",origin_id => "en:US-LA"}
error: ecoscore origin does not exist in taxonomy {origin => "US-MS",origin_id => "en:US-MS"}
error: ecoscore origin does not exist in taxonomy {origin => "US-SC",origin_id => "en:US-SC"}
error: ecoscore origin does not exist in taxonomy {origin => "US-TX",origin_id => "en:US-TX"}
error: ecoscore origin does not exist in taxonomy {origin => "WO",origin_id => "en:WO"}
error: ecoscore origin does not exist in taxonomy {origin => "Eaux internationales",origin_id => "fr:Eaux internationales"}
error: ecoscore origin does not exist in taxonomy {origin => "S\x{e3}o Tom\x{e9} e Pr\x{ed}ncipe",origin_id => "fr:S\x{e3}o Tom\x{e9} e Pr\x{ed}ncipe"}
error: ecoscore origin does not exist in taxonomy {origin => "Territoires fran\x{e7}ais du Sud",origin_id => "fr:Territoires fran\x{e7}ais du Sud"}
Use of uninitialized value $_[0] in substitution (s///) at tests/unit/attributes.t line 221.

Added in the taxonomies

Related issue(s) and discussion

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. labels Jan 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.23%. Comparing base (bf82a79) to head (f3e8c3a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11191      +/-   ##
==========================================
- Coverage   49.25%   49.23%   -0.03%     
==========================================
  Files          78       78              
  Lines       22371    22371              
  Branches     5365     5365              
==========================================
- Hits        11019    11014       -5     
- Misses       9996    10000       +4     
- Partials     1356     1357       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -5695,11 +5825,388 @@ hu: Florida
nl: Florida
pl: Floryda

< en:united-states
en: Georgia, Georgia in the usa, Georgia in the united states, Georgia state, US-GA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have en: Georgia in countries.txt, so we can't have just "Georgia" in origins.txt, or the entries will be combined. I suggest putting "Georgia USA" as the main name. Or "Georgia State".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The State of Georgia would be best: https://en.wikipedia.org/wiki/Georgia_(U.S._state)

Copy link

sonarqubecloud bot commented Jan 6, 2025

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet stephanegigandet merged commit cbe221e into main Jan 6, 2025
14 checks passed
@stephanegigandet stephanegigandet deleted the fix/environmental_score branch January 6, 2025 14:37
stephanegigandet pushed a commit that referenced this pull request Jan 6, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.53.0](v2.52.0...v2.53.0)
(2025-01-06)


### Features

* data-quality - minimum number of ingredients
([#11152](#11152))
([d7881d4](d7881d4)),
closes
[#9732](#9732)
* data-quality/apply-remove_insignificant_digits-for-nutriments
([#11147](#11147))
([a6df72f](a6df72f))
* Top categories for Open Products Facts
([2239473](2239473))
* Top categories for Open Products Facts
([#11171](#11171))
([2239473](2239473))


### Bug Fixes

* allow serving size to be hyphenated
([#11161](#11161))
([7c0df2d](7c0df2d))
* Correct indentation, so that CodeQL can work with the code
([#11166](#11166))
([0178ac2](0178ac2))
* data quality - increase threshold for comparison between fiber and its
subnutriments
([#11145](#11145))
([f0a2682](f0a2682))
* Delete html/images/lang/de/labels/halal.90x90.png
([#11183](#11183))
([80cf708](80cf708))
* environmental_score
([#11191](#11191))
([cbe221e](cbe221e))
* fix OPF PR labelling
([e708ae3](e708ae3))
* fix OPF PR labelling
([#11154](#11154))
([e708ae3](e708ae3))
* fixes for Green-Score
([#11155](#11155))
([7287d8b](7287d8b))
* green-score link
([#11146](#11146))
([abf858a](abf858a))
* nutriscore grade from category change for extra virgin olive oils
([#11156](#11156))
([32d58e0](32d58e0))
* rm nova drilldown field for beauty
([#11193](#11193))
([3f5b654](3f5b654))
* SonarCloud issues
([#11165](#11165))
([b84d545](b84d545))
* warnings in import_convert_carrefour_france
([#11189](#11189))
([4643e3a](4643e3a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove various errors that are polluting the Test suite outputs
4 participants