-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: environmental_score #11191
fix: environmental_score #11191
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11191 +/- ##
==========================================
- Coverage 49.25% 49.23% -0.03%
==========================================
Files 78 78
Lines 22371 22371
Branches 5365 5365
==========================================
- Hits 11019 11014 -5
- Misses 9996 10000 +4
- Partials 1356 1357 +1 ☔ View full report in Codecov by Sentry. |
taxonomies/origins.txt
Outdated
@@ -5695,11 +5825,388 @@ hu: Florida | |||
nl: Florida | |||
pl: Floryda | |||
|
|||
< en:united-states | |||
en: Georgia, Georgia in the usa, Georgia in the united states, Georgia state, US-GA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have en: Georgia in countries.txt, so we can't have just "Georgia" in origins.txt, or the entries will be combined. I suggest putting "Georgia USA" as the main name. Or "Georgia State".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The State of Georgia would be best: https://en.wikipedia.org/wiki/Georgia_(U.S._state)
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🤖 I have created a release *beep* *boop* --- ## [2.53.0](v2.52.0...v2.53.0) (2025-01-06) ### Features * data-quality - minimum number of ingredients ([#11152](#11152)) ([d7881d4](d7881d4)), closes [#9732](#9732) * data-quality/apply-remove_insignificant_digits-for-nutriments ([#11147](#11147)) ([a6df72f](a6df72f)) * Top categories for Open Products Facts ([2239473](2239473)) * Top categories for Open Products Facts ([#11171](#11171)) ([2239473](2239473)) ### Bug Fixes * allow serving size to be hyphenated ([#11161](#11161)) ([7c0df2d](7c0df2d)) * Correct indentation, so that CodeQL can work with the code ([#11166](#11166)) ([0178ac2](0178ac2)) * data quality - increase threshold for comparison between fiber and its subnutriments ([#11145](#11145)) ([f0a2682](f0a2682)) * Delete html/images/lang/de/labels/halal.90x90.png ([#11183](#11183)) ([80cf708](80cf708)) * environmental_score ([#11191](#11191)) ([cbe221e](cbe221e)) * fix OPF PR labelling ([e708ae3](e708ae3)) * fix OPF PR labelling ([#11154](#11154)) ([e708ae3](e708ae3)) * fixes for Green-Score ([#11155](#11155)) ([7287d8b](7287d8b)) * green-score link ([#11146](#11146)) ([abf858a](abf858a)) * nutriscore grade from category change for extra virgin olive oils ([#11156](#11156)) ([32d58e0](32d58e0)) * rm nova drilldown field for beauty ([#11193](#11193)) ([3f5b654](3f5b654)) * SonarCloud issues ([#11165](#11165)) ([b84d545](b84d545)) * warnings in import_convert_carrefour_france ([#11189](#11189)) ([4643e3a](4643e3a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
What
Added in the taxonomies
Related issue(s) and discussion