Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm nova drilldown field for beauty #11193

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

benbenben2
Copy link
Collaborator

What

Remove the nova drilldown field for Open Beauty Facts

+ commented duplicates between labels taxonomies for food and beauty. Make lint made more changes. Look for "# already in food labels.txt" in the code.

Related issue(s) and discussion

@benbenben2 benbenben2 self-assigned this Jan 6, 2025
@benbenben2 benbenben2 requested a review from a team as a code owner January 6, 2025 11:00
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org config labels Jan 6, 2025
Copy link

sonarqubecloud bot commented Jan 6, 2025

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet enabled auto-merge (squash) January 6, 2025 11:31
@stephanegigandet stephanegigandet merged commit 3f5b654 into main Jan 6, 2025
18 checks passed
@stephanegigandet stephanegigandet deleted the fix/rm_nova_drilldown_field_for_beauty branch January 6, 2025 11:34
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.25%. Comparing base (09f5821) to head (8986ad8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11193   +/-   ##
=======================================
  Coverage   49.25%   49.25%           
=======================================
  Files          78       78           
  Lines       22371    22371           
  Branches     5365     5365           
=======================================
  Hits        11019    11019           
  Misses       9996     9996           
  Partials     1356     1356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stephanegigandet pushed a commit that referenced this pull request Jan 6, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.53.0](v2.52.0...v2.53.0)
(2025-01-06)


### Features

* data-quality - minimum number of ingredients
([#11152](#11152))
([d7881d4](d7881d4)),
closes
[#9732](#9732)
* data-quality/apply-remove_insignificant_digits-for-nutriments
([#11147](#11147))
([a6df72f](a6df72f))
* Top categories for Open Products Facts
([2239473](2239473))
* Top categories for Open Products Facts
([#11171](#11171))
([2239473](2239473))


### Bug Fixes

* allow serving size to be hyphenated
([#11161](#11161))
([7c0df2d](7c0df2d))
* Correct indentation, so that CodeQL can work with the code
([#11166](#11166))
([0178ac2](0178ac2))
* data quality - increase threshold for comparison between fiber and its
subnutriments
([#11145](#11145))
([f0a2682](f0a2682))
* Delete html/images/lang/de/labels/halal.90x90.png
([#11183](#11183))
([80cf708](80cf708))
* environmental_score
([#11191](#11191))
([cbe221e](cbe221e))
* fix OPF PR labelling
([e708ae3](e708ae3))
* fix OPF PR labelling
([#11154](#11154))
([e708ae3](e708ae3))
* fixes for Green-Score
([#11155](#11155))
([7287d8b](7287d8b))
* green-score link
([#11146](#11146))
([abf858a](abf858a))
* nutriscore grade from category change for extra virgin olive oils
([#11156](#11156))
([32d58e0](32d58e0))
* rm nova drilldown field for beauty
([#11193](#11193))
([3f5b654](3f5b654))
* SonarCloud issues
([#11165](#11165))
([b84d545](b84d545))
* warnings in import_convert_carrefour_france
([#11189](#11189))
([4643e3a](4643e3a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Disable the NOVA facet on Open Beauty Facts
3 participants