Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow serving size to be hyphenated #11161

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

benbenben2
Copy link
Collaborator

What

allow serving size to be hyphen ("-")

Related issue(s) and discussion

@benbenben2 benbenben2 self-assigned this Dec 21, 2024
@benbenben2 benbenben2 requested a review from a team as a code owner December 21, 2024 15:20
@github-actions github-actions bot added 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧪 tests labels Dec 21, 2024
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Dec 22, 2024
@teolemon teolemon changed the title fix: allow serving size to be hyphen fix: allow serving size to be hyphenated Dec 22, 2024
@benbenben2 benbenben2 merged commit 7c0df2d into main Dec 22, 2024
20 checks passed
@benbenben2 benbenben2 deleted the data-quality/allow-serving-size-to-be-hyphen branch December 22, 2024 11:44
@alexgarel
Copy link
Member

Great @benbenben2 !

stephanegigandet pushed a commit that referenced this pull request Jan 6, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.53.0](v2.52.0...v2.53.0)
(2025-01-06)


### Features

* data-quality - minimum number of ingredients
([#11152](#11152))
([d7881d4](d7881d4)),
closes
[#9732](#9732)
* data-quality/apply-remove_insignificant_digits-for-nutriments
([#11147](#11147))
([a6df72f](a6df72f))
* Top categories for Open Products Facts
([2239473](2239473))
* Top categories for Open Products Facts
([#11171](#11171))
([2239473](2239473))


### Bug Fixes

* allow serving size to be hyphenated
([#11161](#11161))
([7c0df2d](7c0df2d))
* Correct indentation, so that CodeQL can work with the code
([#11166](#11166))
([0178ac2](0178ac2))
* data quality - increase threshold for comparison between fiber and its
subnutriments
([#11145](#11145))
([f0a2682](f0a2682))
* Delete html/images/lang/de/labels/halal.90x90.png
([#11183](#11183))
([80cf708](80cf708))
* environmental_score
([#11191](#11191))
([cbe221e](cbe221e))
* fix OPF PR labelling
([e708ae3](e708ae3))
* fix OPF PR labelling
([#11154](#11154))
([e708ae3](e708ae3))
* fixes for Green-Score
([#11155](#11155))
([7287d8b](7287d8b))
* green-score link
([#11146](#11146))
([abf858a](abf858a))
* nutriscore grade from category change for extra virgin olive oils
([#11156](#11156))
([32d58e0](32d58e0))
* rm nova drilldown field for beauty
([#11193](#11193))
([3f5b654](3f5b654))
* SonarCloud issues
([#11165](#11165))
([b84d545](b84d545))
* warnings in import_convert_carrefour_france
([#11189](#11189))
([4643e3a](4643e3a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality serving size ⭐ top pull request Top pull request. 🧪 tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Serving size: "missing digits" error is too strict: allow entering dash to express missing data
4 participants