Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feat_japanese_nutrition_table #9467

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

benbenben2
Copy link
Collaborator

What

Provide custom nutrition table for Japan.

The following nutrients appear in Japanese products:

熱量 / energy
    (or)
    エネルギー / energy
たんぱく質 / protein
    (or)
    蛋白質 / protein
    (or)
    タンパク質 / protein
脂質      / fat
( - 飽和脂肪   / saturated fat)
(コレステロール / cholesterol)
炭水化物  / glucides
 (- 糖類  	 / sugar )
 (- 食物繊維   / Fibre )
食塩相当量 / salt

Saturated fat, sugar, fibre are not mandatory in Japan.
Hence, for most of the products, the nutriscore cannot be computed.

Sodium seems to be autofilled based on salt value.

Screenshot

This is for "jp-en" prefix page (text is in English but these are japanese products)

Edit page
Screenshot_20231203_202342

product page
Screenshot_20231203_202356

Same in Japanese:
Screenshot_20231203_225459

Screenshot_20231203_225312

Related issue(s) and discussion

  • Fixes #-none

@benbenben2 benbenben2 added Nutrition facts 🇯🇵 Japan https://jp.openfoodfacts.org/ labels Dec 3, 2023
@benbenben2 benbenben2 self-assigned this Dec 3, 2023
@benbenben2 benbenben2 requested a review from a team as a code owner December 3, 2023 21:57
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies Food.pm labels Dec 3, 2023
Copy link

sonarqubecloud bot commented Dec 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e18b065) 49.00% compared to head (8d2f28b) 49.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9467   +/-   ##
=======================================
  Coverage   49.00%   49.00%           
=======================================
  Files          66       66           
  Lines       20421    20421           
  Branches     4904     4904           
=======================================
  Hits        10008    10008           
  Misses       9144     9144           
  Partials     1269     1269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Food.pm 🇯🇵 Japan https://jp.openfoodfacts.org/ Nutrition facts 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants