Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump activemerchant from 1.123.0 to 1.126.0 #9456

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 26, 2022

Bumps activemerchant from 1.123.0 to 1.126.0.

Release notes

Sourced from activemerchant's releases.

v1.126.0

What's Changed

... (truncated)

Changelog

Sourced from activemerchant's changelog.

== Version 1.126.0 (April 15th, 2022)

  • Moneris: Add 3DS MPI field support [esmitperez] #4373
  • StripePI: Add ability to change payment_method_type to confirm_intent [aenand] #4300
  • GlobalCollect: Improve support for Naranja and Cabal card types [dsmcclain] #4286
  • Payflow: Add support for stored credentials [ajawadmirza] #4277
  • Orbital: Don't void $0 auths for Verify [javierpedrozaing] #2487
  • StripePI: Enable Apple Pay and Google Pay payment methods [gasb150] #4252
  • PaySafe: Update unstore method and authorization for redact [ajawadmirza] #4294
  • CyberSource: Add national_tax_indicator fields in authorize and purchase [ajawadmirza] #4299
  • NMI: Update gateway credentials to accept security_key [javierpedrozaing] #4302
  • PaySafe: Fix commit for unstore method [ajawadmirza] #4303
  • Ebanx: Add support for order_number field [ali-hassan] #4304
  • BlueSnap: Add support for idempotency_key field [drkjc] #4305
  • Paymentez: Update capture method to verify by otp for pending transactions [ajawadmirza] #4267
  • BlueSnap: Update refund request and endpoint along with merchant transaction support [ajawadmirza] #4307
  • DecidirPlus: Added authorize, capture, void, and verify methods [ajawadmirza] #4284
  • Paymentez: Fix authorize to call purchase for otp flow [ajawadmirza] #4310
  • Orbital: Indicate support for network tokenization [dsmcclain] #4309
  • IPG: remove uruguay from supported countries [ajawadmirza] #4311
  • Decidir: Add sub_payments sub-fields to gateway [meagabeth] #4315
  • Priority: Add additional fields to purchase and capture requests [dsmcclain] #4301
  • DecidirPlus: Added unstore method [ajawadmirza] #4317
  • Decidir & Decidir Plus: Revise handling of sub_payment sub-fields [meagabeth] #4318
  • DecidirPlus: Update unstore implementation to get token from params [ajawadmirza] #4320
  • CyberSource: Add option for zero amount verify [gasb150] #4313
  • PayU Latam: Refactor message_from method, fix failing remote tests [rachelkirk] #4326
  • Adyen: Add currencies with three decimals places [gasb150] #4322
  • GlobalCollect: Stregthen success criteria for void action [peteroas] #4324
  • Priority Payment Systems - Clean up/refactor gateway file and tests [ali-hassan] #4327
  • SafeCharge: change verify to send 0 amount [dsmcclain] #4332
  • DLocal: add support for force_type field [dsmcclain] #4336
  • Barclaycard SmartPay: Support more nonstandard currencies [jherreraa] #4335
  • DecidirPlus: name_override option on store [naashton] #4338
  • Priority: Update add_purchases_data to return if options[:purchases] is empty [drkjc] #4349
  • Stripe PI: update shipping field to shipping_address [ajawadmirza] #4347
  • DecidirPlus: Handle payment_method_id by card_brand [naashton] #4350
  • DecidirPlus: debit and payment_method_id fields [naashton] #4351
  • Adyen: Include Application ID in adyen authorize and purchase transactions [peteroas] #4343
  • Priority: Add support for replay_id field [drkjc] #4352
  • Stripe PI: standardize shipping_address fields [dsmcclain] #4355
  • Airwallex: support gateway [therufs] #4342
  • Litle: Translate google_pay as android_pay [javierpedrozaing] #4331
  • Braintree: Add ACH support for store [cristian] #4285
  • Simetrik: Add support for Simetrik gateway [simetrik-frank] #4339
  • EBANX: Change amount for Mexico and Chile [flaaviaa] #4337
  • DecidirPlus: Add establishment_name, aggregate_data, sub_payments, card_holder_identification_type, card_holder_identification_number, card_door_number, and card_holder_birthday fields [ajawadmirza] #4361
  • DecidirPlus: Update error_code_from to get error reason id [ajawadmirza] #4364
  • Dlocal: Add three_ds mpi support [cristian] #4345
  • Stripe PI: Add request_three_d_secure field for create_setup_intent [aenand] #4365
  • Adyen: Add verify_amount field for verify [ajawadmirza] #4369

... (truncated)

Commits
  • f7ca1f9 Airwallex: Add support for original_transaction_id
  • a9d5b3a Release v1.126.0 (#4402)
  • eda06d0 Add Cartes Bancaires bin ranges (#4398)
  • f5ba1db Airwallex: Add 3DS Global Support
  • 987ac8b Multiple Gateways: Resolve when/case bug
  • 9d22fb2 NMI: Update post URL
  • cb45b38 Priority: add settled and voided to list of successful response statuses
  • fdec498 Conekta: Fix remote test
  • 15379d2 Priority: Update verify method signature
  • 2f3db70 Rapyd: Update type option to pm_type
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Jul 26, 2022
Copy link
Contributor

@jibees jibees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is pretty sensible I guess.

@jibees jibees requested a review from mkllnk July 26, 2022 15:19
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly covered by release testing. Maybe let's test subscription payments on staging.

@dependabot dependabot bot force-pushed the dependabot/bundler/activemerchant-1.126.0 branch 2 times, most recently from 1ba9e99 to 2d613c1 Compare July 28, 2022 01:09
Bumps [activemerchant](https://github.com/activemerchant/active_merchant) from 1.123.0 to 1.126.0.
- [Release notes](https://github.com/activemerchant/active_merchant/releases)
- [Changelog](https://github.com/activemerchant/active_merchant/blob/master/CHANGELOG)
- [Commits](activemerchant/active_merchant@v1.123.0...v1.126.0)

---
updated-dependencies:
- dependency-name: activemerchant
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/activemerchant-1.126.0 branch from 2d613c1 to 21c0baa Compare July 28, 2022 01:10
@drummer83
Copy link
Contributor

drummer83 commented Aug 1, 2022

@mkllnk Could you please provide some information about what to test here? Thanks! :-)
Adding 'feedback needed' label.

@jibees
Copy link
Contributor

jibees commented Aug 2, 2022

I guess it's a payment with credit card that is expected here.

@mkllnk
Copy link
Member

mkllnk commented Aug 3, 2022

To test:

  • Setup a subscription with a credit card.
  • Let the order cycle close and the card be charged.
  • Receive the confirmation email and see the successful payment in the backend.

@filipefurtad0 filipefurtad0 self-assigned this Aug 11, 2022
@filipefurtad0 filipefurtad0 added the pr-staged-uk staging.openfoodnetwork.org.uk label Aug 11, 2022
@filipefurtad0
Copy link
Contributor

Hey @mkllnk @jibees ,

Had a look into this bump:

Tested a subscription payment:

  • Setup a subscription with a 3D-credit card
  • Triggered the subscription placement and confirmation through the console
  • Received the confirmation email
  • Checked the successful payment in the backoffice and Stripe dashboard

Placed a shopfront order with a credit card as well.

All good, merging!

Note to self: which automated tests do we have around the active merchant gem?

@filipefurtad0 filipefurtad0 merged commit 82f38c9 into master Aug 11, 2022
@filipefurtad0 filipefurtad0 deleted the dependabot/bundler/activemerchant-1.126.0 branch August 11, 2022 16:10
@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Aug 13, 2022
mkllnk added a commit to mkllnk/openfoodnetwork that referenced this pull request Aug 22, 2022
…ation/dependabot/bundler/activemerchant-1.126.0"

This reverts commit 82f38c9, reversing
changes made to 689720b.
mkllnk added a commit to mkllnk/openfoodnetwork that referenced this pull request Aug 22, 2022
…ation/dependabot/bundler/activemerchant-1.126.0"

This reverts commit 82f38c9, reversing
changes made to 689720b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants