Bump rspec-rails from 5.1.2 to 6.0.1 #9850

dependabot · 2022-10-24T09:03:30Z

Bumps rspec-rails from 5.1.2 to 6.0.1.

Changelog

6.0.1 / 2022-10-18

Full Changelog

Bug Fixes:

Prevent tagged logged support in Rails 7 calling #name. (Jon Rowe, #2625)

6.0.0 / 2022-10-10

Full Changelog

Enhancements:

Support Rails 7

Template tweaks to remove instance variables from generated specs. (Takuma Ishikawa, #2599)

Generators now respects default path configuration option. (@vivekmiyani, #2508)

Breaking Changes:

Drop support for Rails below 6.1

Drop support for Ruby below 2.5 (following supported versions of Rails 6.1)

Change the order of after_teardown from after to around in system specs to improve compatibility with extensions and Capybara. (Tim Diggins, #2596)

Deprecations:

Deprecates integration spec generator (rspec:integration) which was an alias of request spec generator (rspec:request) (Luka Lüdicke, #2374)

Commits

ce70c2f v6.0.1
8f867f4 Changelog for 6.0.1
ac38623 Changelog for #2625
bc5a3c0 Merge pull request #2625 from rspec/replacement-tagged-logger-support
73c0989 Merge pull request #2626 from rspec/fix-build
0646044 v6.0.0
7cd6f93 s/upload_backups_spec.rb/upload_backups_job_spec.rb/g
8016684 Merge pull request #2587 from rspec/shanecav84/include-tagged-logging
0b4d164 Fixed typo
396c68f This updates Rubocop and uses the .rubocop_rspec_base.yml for consistency
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

jibees · 2022-10-27T07:06:31Z

@dependabot-bot rebase

sigmundpetersen · 2022-10-28T07:49:49Z

@dependabot-bot recreate

dependabot · 2022-11-11T22:01:11Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

sigmundpetersen · 2022-11-11T22:23:43Z

@dependabot-bot recreate

filipefurtad0 · 2022-12-06T15:28:06Z

@dependabot-bot recreate

filipefurtad0 · 2022-12-06T17:30:59Z

One spec failing with:

Failures:

  1) Spree::Admin::BaseController rendering as json ActiveModelSerializer when data is an object when an ams prefix is passed passes a prefix to the serializer method and renders with serializer
     Failure/Error: render options.merge(json: data, serializer: serializer(ams_prefix))
     
       #<Spree::Admin::BaseController:0x0000000002fd50> received :render with unexpected arguments
         expected: ({:json=>{:attr=>"value"}, :serializer=>"SerializerClass"}) (keyword arguments)
              got: ({:json=>{:attr=>"value"}, :serializer=>"SerializerClass"}) (options hash)
       Diff:
       
     # ./app/controllers/spree/admin/base_controller.rb:96:in `render_as_json'
     # ./spec/controllers/spree/admin/base_controller_spec.rb:28:in `block (5 levels) in <top (required)>'

This seems related:
rspec/rspec-mocks#1460

sigmundpetersen · 2022-12-06T18:27:41Z

Yes, also discussed in the last bump #9430

filipefurtad0 · 2022-12-06T18:34:28Z

Yes, also discussed in the last bump #9430

Ah, thank you @sigmundpetersen - totally forgot about that discussion 🙈

jibees · 2023-01-05T09:58:34Z

@dependabot-bot rebase

Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 5.1.2 to 6.0.1. - [Release notes](https://github.com/rspec/rspec-rails/releases) - [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md) - [Commits](rspec/rspec-rails@v5.1.2...v6.0.1) --- updated-dependencies: - dependency-name: rspec-rails dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

The syntax was ambiguous and nwer version of rspec-rails catch that.

dacook

👍 Great job

dacook · 2023-02-01T00:42:38Z

spec/controllers/spree/admin/base_controller_spec.rb

@@ -24,7 +24,7 @@ def index

        it "passes a prefix to the serializer method and renders with serializer" do
          expect(controller).to receive(:serializer).with(prefix) { "SerializerClass" }
-          expect(controller).to receive(:render).with(json: data, serializer: "SerializerClass")
+          expect(controller).to receive(:render).with({ json: data, serializer: "SerializerClass" })


Interesting, I would have thought that Rails would have changed the controller arguments over to keyword arguments, but I guess they didn't.

dacook · 2023-02-01T00:43:54Z

Merging without manual test, as it only affects the test environment, which has already been confirmed.

filipefurtad0 · 2023-02-01T12:28:06Z

Yay - thanks for addressing this one 🎉

filipefurtad0 · 2023-02-01T12:40:52Z

Interesting, that this rspec-rails bump also upgrades activemerchant (1.126.0) 👀
(the reason I'm raising this is #9580, which #9456 introduced - I'll test this in master and check if checkout while saving a card breaks)

filipefurtad0 · 2023-02-01T13:13:08Z

I don't really understand it, but:

I could not reproduce the bug anymore (which is good but puzzling, nonetheless)
I would not think that bumping a gem which acts only under the :test environment could upgrade other gems as well -> dependency bumps have indeed huge 💥 potential -> I'm still thinking about the discussion from delivery-circle (on how to speed manual testing)

dacook · 2023-02-01T23:29:51Z

Yes, that is strange! I've reverted this (d5ae5c9) due to the unexpected update of activemerchant.
It has been re-opened by dependabot in #10356 , which has the same problem.

dependabot bot added dependencies ruby Pull requests that update Ruby code labels Oct 24, 2022

dependabot bot force-pushed the dependabot/bundler/rspec-rails-6.0.1 branch from f30d2e6 to 1c373c7 Compare October 25, 2022 03:34

filipefurtad0 mentioned this pull request Oct 26, 2022

Dependabot PRs run both on the push and pull request triggers #9882

Closed

dependabot bot force-pushed the dependabot/bundler/rspec-rails-6.0.1 branch from 1c373c7 to 7754fe8 Compare October 26, 2022 22:53

dependabot bot force-pushed the dependabot/bundler/rspec-rails-6.0.1 branch from 7754fe8 to 5fa73c0 Compare October 27, 2022 07:07

dependabot bot force-pushed the dependabot/bundler/rspec-rails-6.0.1 branch 2 times, most recently from fc7e8c7 to 53cbfe3 Compare November 2, 2022 00:11

dependabot bot force-pushed the dependabot/bundler/rspec-rails-6.0.1 branch 2 times, most recently from 2cc4194 to 1860978 Compare November 18, 2022 13:51

dependabot bot force-pushed the dependabot/bundler/rspec-rails-6.0.1 branch from 1860978 to 8cc64e4 Compare November 24, 2022 05:12

dependabot bot force-pushed the dependabot/bundler/rspec-rails-6.0.1 branch from 8cc64e4 to 4200b62 Compare December 6, 2022 15:30

dependabot bot force-pushed the dependabot/bundler/rspec-rails-6.0.1 branch from 4200b62 to 27f09a4 Compare January 5, 2023 09:59

dependabot bot force-pushed the dependabot/bundler/rspec-rails-6.0.1 branch from 27f09a4 to 1313b55 Compare January 20, 2023 10:33

mkllnk self-assigned this Jan 31, 2023

Clarify expecting a hash, not keyword arguments

d3b80b7

The syntax was ambiguous and nwer version of rspec-rails catch that.

mkllnk requested review from jibees and dacook January 31, 2023 05:54

dacook approved these changes Feb 1, 2023

View reviewed changes

dacook merged commit 01c6a8b into master Feb 1, 2023

dacook deleted the dependabot/bundler/rspec-rails-6.0.1 branch February 1, 2023 00:43

dacook mentioned this pull request Feb 1, 2023

Bump activemerchant from 1.123.0 to 1.126.0 #9593

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump rspec-rails from 5.1.2 to 6.0.1 #9850

Bump rspec-rails from 5.1.2 to 6.0.1 #9850

dependabot bot commented on behalf of github Oct 24, 2022 •

edited

Loading

jibees commented Oct 27, 2022

sigmundpetersen commented Oct 28, 2022

dependabot bot commented on behalf of github Nov 11, 2022

sigmundpetersen commented Nov 11, 2022

filipefurtad0 commented Dec 6, 2022

filipefurtad0 commented Dec 6, 2022

sigmundpetersen commented Dec 6, 2022

filipefurtad0 commented Dec 6, 2022

jibees commented Jan 5, 2023

dacook left a comment

dacook Feb 1, 2023

dacook commented Feb 1, 2023

filipefurtad0 commented Feb 1, 2023

filipefurtad0 commented Feb 1, 2023 •

edited

Loading

filipefurtad0 commented Feb 1, 2023 •

edited

Loading

dacook commented Feb 1, 2023

Bump rspec-rails from 5.1.2 to 6.0.1 #9850

Bump rspec-rails from 5.1.2 to 6.0.1 #9850

Conversation

dependabot bot commented on behalf of github Oct 24, 2022 • edited Loading

6.0.1 / 2022-10-18

6.0.0 / 2022-10-10

jibees commented Oct 27, 2022

sigmundpetersen commented Oct 28, 2022

dependabot bot commented on behalf of github Nov 11, 2022

sigmundpetersen commented Nov 11, 2022

filipefurtad0 commented Dec 6, 2022

filipefurtad0 commented Dec 6, 2022

sigmundpetersen commented Dec 6, 2022

filipefurtad0 commented Dec 6, 2022

jibees commented Jan 5, 2023

dacook left a comment

Choose a reason for hiding this comment

dacook Feb 1, 2023

Choose a reason for hiding this comment

dacook commented Feb 1, 2023

filipefurtad0 commented Feb 1, 2023

filipefurtad0 commented Feb 1, 2023 • edited Loading

filipefurtad0 commented Feb 1, 2023 • edited Loading

dacook commented Feb 1, 2023

dependabot bot commented on behalf of github Oct 24, 2022 •

edited

Loading

filipefurtad0 commented Feb 1, 2023 •

edited

Loading

filipefurtad0 commented Feb 1, 2023 •

edited

Loading