♻️(frontend) replace Paragraph grommet #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
changed the base branch from
master
to
feature/anthony/replace-text-grommet
AntoLC
force-pushed
the
feature/anthony/replace-paragraph-grommet
branch
from
a7e1736
to
fbc746b
Compare
kernicPanel
reviewed
Oct 2, 2023
src/frontend/apps/lti_site/apps/deposit/components/Dashboard/DashboardStudent/index.tsx
Outdated
Show resolved
Hide resolved
...andalone_site/src/features/Playlist/features/UpdatePlaylist/components/AddUserAccessForm.tsx
Outdated
Show resolved
Hide resolved
...room/src/components/ClassroomWidgetProvider/widgets/SupportSharing/UploadDocuments/index.tsx
Show resolved
Hide resolved
src/frontend/packages/lib_components/src/common/ErrorComponents/BoundaryScreenError/index.tsx
Show resolved
Hide resolved
src/frontend/packages/lib_video/src/components/common/PictureInPictureLayer/index.spec.tsx
Outdated
Show resolved
Hide resolved
...ib_video/src/components/live/Teacher/Wrapper/Controls/TeacherLiveLifecycleControls/index.tsx
Show resolved
Hide resolved
...ib_video/src/components/live/Teacher/Wrapper/Controls/TeacherLiveLifecycleControls/index.tsx
Show resolved
Hide resolved
...ntend/packages/lib_video/src/components/live/Teacher/Wrapper/TeacherLiveTypeSwitch/index.tsx
Show resolved
Hide resolved
...ntend/packages/lib_video/src/components/live/Teacher/Wrapper/TeacherLiveTypeSwitch/index.tsx
Show resolved
Hide resolved
src/frontend/packages/lib_video/src/components/live/common/ViewersList/index.tsx
Show resolved
Hide resolved
kernicPanel
approved these changes
Oct 3, 2023
lunika
approved these changes
Oct 3, 2023
AntoLC
force-pushed
the
feature/anthony/replace-text-grommet
branch
7 times, most recently
from
f14cfc0
to
ade02f7
Compare
Base automatically changed from
feature/anthony/replace-text-grommet
to
master
October 4, 2023 09:22
AntoLC
force-pushed
the
feature/anthony/replace-paragraph-grommet
branch
from
89ef131
to
b1df180
Compare
We replace the Grommet Paragraph component with our own Text component based on the Cunnigham design system.
AntoLC
force-pushed
the
feature/anthony/replace-paragraph-grommet
branch
from
b1df180
to
ad457b1
Compare
lunika
added a commit
that referenced
this pull request
Oct 19, 2023
Added - Generic video LTI url - Display complete error message in frontend - Generic classroom LTI url - Generic LTI cartridge (xml configuration) - Display LTI warning message for generic urls regarding course copy - configure homepage banner using SiteConfig model - setting BBB_INVITE_TOKEN_BANNED_LIST - Add transcode_pipeline property to video model Changed - Replace ngrok with localtunnel to serve marsha on a public domain with stable urls and allow to run multiple tunnels at the same time - Replace all the loaders by Cunningham Loader (#2436) - Replace grommet Text (#2427) - Replace grommet Paragraph (#2435) - Remove cross on login image (#2451) - Replace grommet Checkbox and Pagination (#2437) Fixed - Markdown save sent previously saved content - Force to end BBB meeting when creation fail
lunika
added a commit
that referenced
this pull request
Oct 19, 2023
Added - Generic video LTI url - Display complete error message in frontend - Generic classroom LTI url - Generic LTI cartridge (xml configuration) - Display LTI warning message for generic urls regarding course copy - configure homepage banner using SiteConfig model - setting BBB_INVITE_TOKEN_BANNED_LIST - Add transcode_pipeline property to video model Changed - Replace ngrok with localtunnel to serve marsha on a public domain with stable urls and allow to run multiple tunnels at the same time - Replace all the loaders by Cunningham Loader (#2436) - Replace grommet Text (#2427) - Replace grommet Paragraph (#2435) - Remove cross on login image (#2451) - Replace grommet Checkbox and Pagination (#2437) Fixed - Markdown save sent previously saved content - Force to end BBB meeting when creation fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace the grommet Paragraph component by our custom component Text component base on the Cunningham design system.
Proposal