♻️ replace grommet Image and Grid #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-image
branch
5 times, most recently
from
b1d662d
to
1f213a8
Compare
kernicPanel
approved these changes
Nov 29, 2023
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-image
branch
3 times, most recently
from
cdcc6a8
to
5ef8042
Compare
We replace the grommet Image components by a custom Image component.
We replace the grommet Grid components by a custom Grid component based on Typo component.
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-image
branch
from
5ef8042
to
4ce8f0c
Compare
lunika
added a commit
that referenced
this pull request
Jun 24, 2024
Added - Add scaleway storage configuration - Add Peertube pipeline to VOD - Celery task queue - Refactor video S3 deletion - Add thumbnail celery task - Add shared live media celery task - Add timed text track celery task - Add form submission with enter key when entering a classroom - Persist username used on classroom join Changed - Replace CRA by Vite (#2530) - Replace grommet Image and Grid component (#2518) - Optimized apps bundle (#2528) - Launch transcoding through a celery task Fixed - Correctly set startime with filtering medialive logs - Remove non existing fields in PortabilityRequestAdmin - Correctly send xapi statement to a configured LRS - Correctly send xapi video download statements
lunika
added a commit
that referenced
this pull request
Jun 26, 2024
Added - Add scaleway storage configuration - Add Peertube pipeline to VOD - Celery task queue - Refactor video S3 deletion - Add thumbnail celery task - Add shared live media celery task - Add timed text track celery task - Add form submission with enter key when entering a classroom - Persist username used on classroom join Changed - Replace CRA by Vite (#2530) - Replace grommet Image and Grid component (#2518) - Optimized apps bundle (#2528) - Launch transcoding through a celery task Fixed - Correctly set startime with filtering medialive logs - Remove non existing fields in PortabilityRequestAdmin - Correctly send xapi statement to a configured LRS - Correctly send xapi video download statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We replace the grommet Image components by a custom Image component.
Proposal