fix(docker/awscli): upgrade to python3 and install python3-dev #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change (not sure what) started causing `pip install awscli` to fail without the python2-dev package. Install it to fix the build errors. Travis build log: https://travis-ci.com/github/opengovsg/postmangovsg/jobs/498665286
Note: 1. Removed `py-pip` since it seems unnecessary 2. Use `python3 -m pip` instead of `pip` to avoid using Python2's pip (unlikely since Python2 should not be installed, but just in case)
zwliew
changed the title
zwliew
changed the title
lamkeewei
approved these changes
Apr 19, 2021
lamkeewei
added a commit
that referenced
this pull request
Apr 19, 2021
* develop: fix(docker/awscli): upgrade to python3 and install python3-dev (#1140) feat(frontend): set up test fixtures and deployment processes (#1086) feat: allow activation of SNS as fallback for all SMS campaigns (#1019) 1.22.4 fix: re-fetch campaign details after campaign is sent (#1116) chore: upgrade dependencies (#1120) chore: fix build warnings (#1103) fix(moment): disable periodic updates for react-moment components (#1127) fix: avoid calling setState when components are unmounted (#1109) chore: add callback server (#1112)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A recent change (not sure what) started causing
pip install awsclitofail without the python2-dev package. This causes backend and worker
builds on Travis to fail.
Travis build log: https://travis-ci.com/github/opengovsg/postmangovsg/jobs/498665286
Solution
Improvements:
python3and removepy-pippython3-devon the backend and worker Docker instancesBefore & After Screenshots
There are no visual changes.
Tests
backendandworkerbuilds and deployments on Travis, AWS EBS, and AWS ECS succeed.Deploy Notes
There are no deploy notes.
Todo
Notes regarding AWS CLI v2
There is a prebuilt binary, but it depends on glibc. Our Docker image (Alpine) only includes musl libc, so we can't use the binary as is.
Options:
Both of these options seem more trouble than they're worth, so I've decided not to upgrade to v2 for now.
References