remove override keyword. code now compiles. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drortirosh
reviewed
Feb 14, 2023
| @@ -15,7 +15,7 @@ contract CaptureTheFlag is ERC2771Recipient { | |||
| _setTrustedForwarder(forwarder); | |||
| } | |||
|
|
|||
| string public override versionRecipient = "3.0.0"; | |||
There was a problem hiding this comment.
better remove it completely, since it is unused (was in use in previous version)
however, we keep this repo clean, with a single commit for each step, so we will have to re-build it with this change.
There was a problem hiding this comment.
@drortirosh great suggestion. I do agree with you. Build a clean repo. I want to contribute to this and do this for you guys. What would be the way forward?
There was a problem hiding this comment.
@drortirosh please note that this is a "generated" branch - please recreate the workshop for beta.3 when you have the time! 😀
There was a problem hiding this comment.
@forshtat I also want to contribute to this recreation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling, the below error was produced
CompileError: TypeError: Public state variable has override specified but does not override anything.I removed the
overridespecifier and then compiled the code and did test the overall execution. It now runs fine as expected.