Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove override keyword. code now compiles. #12

Open
wants to merge 1 commit into
base: 2-workshop-with-gsn
Choose a base branch
from
Open

remove override keyword. code now compiles. #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/CaptureTheFlag.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ contract CaptureTheFlag is ERC2771Recipient {
_setTrustedForwarder(forwarder);
}

string public override versionRecipient = "3.0.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better remove it completely, since it is unused (was in use in previous version)
however, we keep this repo clean, with a single commit for each step, so we will have to re-build it with this change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drortirosh great suggestion. I do agree with you. Build a clean repo. I want to contribute to this and do this for you guys. What would be the way forward?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drortirosh please note that this is a "generated" branch - please recreate the workshop for beta.3 when you have the time! 😀

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forshtat I also want to contribute to this recreation.

string public versionRecipient = "3.0.0";

function captureTheFlag() external {
address previousHolder = currentHolder;
Expand Down