-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Netatmo] Polling leads to missing values in some channels - Smart Video Doorbell #13002
Comments
@clinique : any news? |
Reading again this issue, I understand that something is not correctly handled when an event contains sub-event(s). The sub-event(s) would be ignored. |
This issue has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/how-to-get-netatmo-doorbell-working/145303/6 |
I adressed this one while working on the resolution of #15883, the PR is this one : #16681 SubEvents are now handled. One event can have multiple subevent and each sub will be handled sequentially. |
@clinique : is this issue now fixed with the last merges ? |
From my standpoint and understanding of the issue, yes. |
Unfortunately, I cannot reopen the issue. The issue is not fixed. Affected channels: Example for last-event#local-video-url:
Could you please reopen the issue. If you need more logs, please contact me. |
Currently, I'm using a workaround to have the lastest state of the items, by adding the state if not NULL to a temporary item via a jython rule.
|
@clinique are you able to comment? You seem to be the expert on this binding ;-) |
I'm coming back on this issue. |
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Hello @HaKuNaCH . Could you please try this patched version and give me your feed-back. |
Thanks @clinique |
Here are my findings. These are still NOK -> they are updated correctly on event, but finally got updated with NULL again
zcat -f events.log* | grep "'DoorbellVignette'" | sort
These are "partially" OK -> but periodically updated to NULL, afterwards they are updated again with the last state
zcat -f events.log* | grep "'DoorbellVignetteUrl'" | sort
These are OK -> no update to NULL
zcat -f events.log* | grep "'DoorbellLastVideoLocalURL'" | sort
zcat -f events.log* | grep "'DoorbellLastVideoVpnURL'" | sort
|
Thanks for your detailed analysis @HaKuNaCH , it is very helpfull. So here's a second corrective version. Let me know. BR |
Here are my findings. These are still NOK -> they are updated correctly on event, but finally got updated with NULL again
zcat -f events.log* | grep "'DoorbellVignette'" | sort
These are now OK -> no longer update to NULL
zcat -f events.log* | grep "'DoorbellVignetteUrl'" | sort
These are still OK -> no update to NULL
zcat -f events.log* | grep "'DoorbellLastVideoLocalURL'" | sort
zcat -f events.log* | grep "'DoorbellLastVideoVpnURL'" | sort
|
@HaKuNaCH , we're progressing. I will try to provide you with yet another patch soon. |
I think I catched the reason why Vignette and Snapshot may not be present, while their url are : #14838 : they expire after five minutes. |
Indeed, then it looks like the issue is resolved with your recent adjustments. |
I'll update it, taking in account the expires_at info. You'll have another patch soon. |
Here's a new patch |
Tested. |
* Adressing issue #13002 * Second row of url validity check * Take snapshot expiration in account Signed-off-by: Gaël L'hopital <gael@lhopital.org>
* Adressing issue openhab#13002 * Second row of url validity check * Take snapshot expiration in account Signed-off-by: Gaël L'hopital <gael@lhopital.org>
* Adressing issue openhab#13002 * Second row of url validity check * Take snapshot expiration in account Signed-off-by: Gaël L'hopital <gael@lhopital.org> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
* Adressing issue openhab#13002 * Second row of url validity check * Take snapshot expiration in account Signed-off-by: Gaël L'hopital <gael@lhopital.org>
* Adressing issue openhab#13002 * Second row of url validity check * Take snapshot expiration in account Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Issue came-up during the webhook investigations in :
#12972 (comment)
Expected Behavior
Periodical polling should deliver the values from /getevents
Current Behavior
Polling does update the following channels with NULL:
Possible Solution
Values must be taken from /getevents call.
Example (I left 1 event in, but all the follwowing events also contain the same attributes and all with values):
If required, I can also post examples from:
/homedata
/homestatus
According to the documentation, all other GET API's are deprecated
https://dev.netatmo.com/apidocumentation/security#documentation
Steps to Reproduce (for Bugs)
The text was updated successfully, but these errors were encountered: