Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netatmo] Presence sub events were not updated #16681

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Apr 23, 2024

SubEvents had no cameraID set, so were not dispatched to the appropriate thing.

Partially resolves issue #15883

Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique added the bug An unexpected problem or unintended behavior of an add-on label Apr 23, 2024
@clinique clinique self-assigned this Apr 23, 2024
@clinique clinique requested a review from lolodomo as a code owner April 23, 2024 23:47
Signed-off-by: clinique <gael@lhopital.org>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 01e8e1c into openhab:main Apr 28, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Apr 28, 2024
@clinique clinique deleted the netatmo_15883_2 branch April 28, 2024 22:42
clinique added a commit to clinique/openhab-addons that referenced this pull request Apr 29, 2024
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
lolodomo pushed a commit that referenced this pull request Apr 29, 2024
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
* Making sub event work
Signed-off-by: clinique <gael@lhopital.org>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
* Making sub event work
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* Making sub event work
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* Making sub event work
Signed-off-by: clinique <gael@lhopital.org>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* Making sub event work
Signed-off-by: clinique <gael@lhopital.org>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants