Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boschshc] Upgrade to REST API version 3.2 #15053

Closed
david-pace opened this issue Jun 6, 2023 · 8 comments · Fixed by #15067
Closed

[boschshc] Upgrade to REST API version 3.2 #15053

david-pace opened this issue Jun 6, 2023 · 8 comments · Fixed by #15067
Assignees
@david-pace
Labels
enhancement An enhancement or new feature for an existing add-on patch A PR that has been cherry-picked to a patch release branch

Comments

@david-pace
Copy link
Member

Today Bosch announced that in July the Smart Home Controllers will receive an update which does not support REST API version 2.x anymore (BoschSmartHome/bosch-shc-api-docs#80).

This means that we have to update the openHAB binding because we currently use API version 2.1.
@david-pace david-pace added the enhancement An enhancement or new feature for an existing add-on label Jun 6, 2023
@david-pace david-pace self-assigned this Jun 6, 2023
@GerdZanker
Copy link
Contributor

The REST API will be updated in about one month and could break existing functionality.
Is there a way to provide a change for the released openhab v3.4.x bindings to fix things sooner?
A usual pull request is merged to main and therefore to 4.0.0-SNAPSHOT as far as I know.

@david-pace david-pace changed the title [boschshc] Upgrade to REST API version 3.0 [boschshc] Upgrade to REST API version 3.2 Jun 8, 2023
david-pace added a commit to david-pace/openhab-addons that referenced this issue Jun 8, 2023
@david-pace
[boschshc] Upgrade to REST API version 3.2 (openhab#15053)
e212ecc 
closes openhab#15053

Signed-off-by: David Pace <dev@davidpace.de>
@david-pace david-pace mentioned this issue Jun 8, 2023
Merged
@jlaur
Copy link
Contributor

jlaur commented Jun 8, 2023

Is there a way to provide a change for the released openhab v3.4.x bindings to fix things sooner?

We can cherry-pick the commit into the 3.4.x branch after the PR branch is merged into main.

david-pace added a commit to david-pace/openhab-addons that referenced this issue Jun 8, 2023
@david-pace
[boschshc] Upgrade to REST API version 3.2 (openhab#15053)
f8a2a87 
closes openhab#15053

Signed-off-by: David Pace <dev@davidpace.de>
jlaur pushed a commit that referenced this issue Jun 11, 2023
@david-pace
[boschshc] Upgrade to REST API version 3.2 (#15053) (#15067)
13a036e 
closes #15053

Signed-off-by: David Pace <dev@davidpace.de>
@david-pace
Copy link
Member Author

david-pace commented Jun 11, 2023 •
edited
Loading

@jlaur can you please point me into the right direction about how to cherry-pick this commit onto the 3.4.x branch? I can currently only see branches for 3.0.x, 3.1.x and 3.2.x on the origin side.

@jlaur
Copy link
Contributor

jlaur commented Jun 12, 2023

@jlaur can you please point me into the right direction about how to cherry-pick this commit onto the 3.4.x branch? I can currently only see branches for 3.0.x, 3.1.x and 3.2.x on the origin side.

Only maintainers can do this. I'll try to remember to do this when I'm home from work today. Feel free to ping me if I fail. 🙂

jlaur pushed a commit that referenced this issue Jun 12, 2023
@david-pace @jlaur
[boschshc] Upgrade to REST API version 3.2 (#15053) (#15067)
00dae6f 
closes #15053

Signed-off-by: David Pace <dev@davidpace.de>
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this issue Jun 19, 2023
@david-pace @tburri-alstom
[boschshc] Upgrade to REST API version 3.2 (openhab#15053) (openhab#1…
18d5fbf 
…5067)

closes openhab#15053

Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/will-there-be-a-bosch-smart-home-binding/8910/141

@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Jul 11, 2023
@jlaur
Copy link
Contributor

jlaur commented Jul 11, 2023

@kaikreuzer - we have another broken binding, this time not caused by cloud services, but a firmware upgrade. There is a fix cherry-picked into 3.4.x. I'm not sure how much is needed to trigger a hotfix?

@kaikreuzer
Copy link
Member

Let's say we definitely do a 3.4 patch release still in July and check what other issues we might want to backport as well, so that it becomes valuable for more people than boschshc users.

@jlaur
Copy link
Contributor

jlaur commented Jul 12, 2023

Let's say we definitely do a 3.4 patch release still in July and check what other issues we might want to backport as well, so that it becomes valuable for more people than boschshc users.

Agreed. There will also be a backport of #15187.

matchews pushed a commit to matchews/openhab-addons that referenced this issue Aug 9, 2023
@david-pace @matchews
[boschshc] Upgrade to REST API version 3.2 (openhab#15053) (openhab#1…
43ba8b7 
…5067)

closes openhab#15053

Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this issue Mar 27, 2024
@david-pace @austvik
[boschshc] Upgrade to REST API version 3.2 (openhab#15053) (openhab#1…
cd77e3c 
…5067)

closes openhab#15053

Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-pace david-pace

Labels
enhancement An enhancement or new feature for an existing add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[boschshc] Upgrade to REST API version 3.2 david-pace/openhab-addons
5 participants
@GerdZanker @kaikreuzer @openhab-bot @david-pace @jlaur