Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boschshc] Upgrade to REST API version 3.2 #15067

Merged
merged 1 commit into from
Jun 11, 2023
Merged

[boschshc] Upgrade to REST API version 3.2 #15067

merged 1 commit into from
Jun 11, 2023

Conversation

david-pace
Copy link
Member

closes #15053

@david-pace david-pace requested a review from GerdZanker as a code owner June 8, 2023 20:29
@david-pace david-pace added the enhancement An enhancement or new feature for an existing add-on label Jun 8, 2023
@david-pace
Copy link
Member Author

@GerdZanker I updated to the latest API version that is documented in the Postman collection (3.2). It seems like everything still works. I tested all channels of the hardware that I have available. If possible it would be great if you could check with your hardware as well.

@david-pace
[boschshc] Upgrade to REST API version 3.2 (openhab#15053)
f8a2a87 
closes openhab#15053

Signed-off-by: David Pace <dev@davidpace.de>
@david-pace david-pace force-pushed the 15053-rest-api-3.2 branch from e212ecc to f8a2a87 Compare June 8, 2023 21:25
@jlaur jlaur added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jun 9, 2023
@jlaur
Copy link
Contributor

jlaur commented Jun 9, 2023

@david-pace - I have added the label "additional testing preferred" according to your #15067 (comment). You can remove this label when the PR is ready to be merged. Thanks!

@GerdZanker
Copy link
Contributor

@GerdZanker I updated to the latest API version that is documented in the Postman collection (3.2). It seems like everything still works. I tested all channels of the hardware that I have available. If possible it would be great if you could check with your hardware as well.

Hello @david-pace, I have the same test results.
It seems like everything still works. I tested the discovery of bridge and devices and the channels of few devices.
My SHC hardware reports the following supported "apiVersions":["2.9","3.5"]. Therefore I think the binding is now prepared for the next SHC software update where the support for 2.x is dropped.
Thank you for your fast reaction on the announcement.

@david-pace david-pace removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jun 11, 2023
jlaur
jlaur approved these changes Jun 11, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@jlaur jlaur merged commit 13a036e into openhab:main Jun 11, 2023
@jlaur jlaur added this to the 4.0 milestone Jun 11, 2023
@david-pace david-pace deleted the 15053-rest-api-3.2 branch June 11, 2023 21:19
jlaur pushed a commit that referenced this pull request Jun 12, 2023
@david-pace @jlaur
[boschshc] Upgrade to REST API version 3.2 (#15053) (#15067)
00dae6f 
closes #15053

Signed-off-by: David Pace <dev@davidpace.de>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Jun 12, 2023
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
@david-pace @tburri-alstom
[boschshc] Upgrade to REST API version 3.2 (openhab#15053) (openhab#1…
18d5fbf 
…5067)

closes openhab#15053

Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
@david-pace @matchews
[boschshc] Upgrade to REST API version 3.2 (openhab#15053) (openhab#1…
43ba8b7 
…5067)

closes openhab#15053

Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@david-pace @austvik
[boschshc] Upgrade to REST API version 3.2 (openhab#15053) (openhab#1…
cd77e3c 
…5067)

closes openhab#15053

Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@GerdZanker GerdZanker GerdZanker approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[boschshc] Upgrade to REST API version 3.2
3 participants
@david-pace @jlaur @GerdZanker