-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iCloud] Find my Phone don't work #15333
Comments
Any news? It also don't work with the actual Update. |
I have exactly the same issue |
I'm having the same issue and have been for a while. I'm currently on 4.0.2 and pasted my trace results below.
|
With OpenHAB 4.1.0 the bug is not fixed. |
I think I found out the cause for this issue. The playSound API expects the device "id" to address the device. With #14660 we changed the binding to use the "deviceDiscoveryId" because it turned out that "id" changes over time. |
Not knowing the details, this sounds very plausible. Here’s another tidbit
of information that may support your theory, the format of the ID for my 2
older phones that work is a long string, but the 15 phone is much shorter.
Like 10 characters or so.
Assuming you found it, is this a fixable issue?
Marty
…On Fri, Feb 2, 2024 at 3:04 AM Simon Spielmann ***@***.***> wrote:
I think I found out the cause for this issue. The playSound API expects
the device "id" to address the device. With #14660
<#14660> we changed the
binding to use the "deviceDiscoveryId" because it turned out that "id"
changes over time.
—
Reply to this email directly, view it on GitHub
<#15333 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM4INWJ7WTURSI4XIMHEEITYRST25AVCNFSM6AAAAAA2475YSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRTGM3TAMJQG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Can you come up with a PR or testable jar? |
In principle yes, but the fix will take sometime and currently I'm a bit busy. |
Any progress here? |
Nope :-( Sorry |
I created a PR which should fix the issue. Works for me ;-) |
Unfortunately I can't test this right now. I'm still on 4.3.1. I tried an
upgrade but got tons of errors, and I don't have time to troubleshoot the
upgrade. Hopefully someone else can confirm this works. We've all been
waiting for an update.
Marty
…On Wed, Jun 5, 2024 at 9:08 AM Simon Spielmann ***@***.***> wrote:
I created a PR which should fix the issue. Works for me ;-)
Please test with a fixed version of the binding here
https://github.com/maihacke/openhab-addons/releases/tag/15333-icloud-findmy-rc0
—
Reply to this email directly, view it on GitHub
<#15333 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM4INWKRJJ643U373CML2FLZF4LUPAVCNFSM6AAAAAA2475YSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQGA4TCNJYGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Is this fix already part of an official release? |
To determine if it is part of the stable release, you can ask, but you can also easily find it by yoursefl :-) |
The find my phone function don't work anymore with Openhab 4.
Log output
2023-07-30 08:47:45.099 [ERROR] [nal.common.AbstractInvocationHandler] - An error occurred while calling method 'ThingHandler.handleCommand()' on 'org.openhab.binding.icloud.internal.handler.ICloudDeviceHandler@5fec49': Retry finally failed.
org.openhab.binding.icloud.internal.RetryException: Retry finally failed.
at org.openhab.binding.icloud.internal.handler.ICloudAccountBridgeHandler.callApiWithRetryAndExceptionHandling(ICloudAccountBridgeHandler.java:216) ~[?:?]
at org.openhab.binding.icloud.internal.handler.ICloudAccountBridgeHandler.findMyDevice(ICloudAccountBridgeHandler.java:290) ~[?:?]
at org.openhab.binding.icloud.internal.handler.ICloudDeviceHandler.handleCommand(ICloudDeviceHandler.java:145) ~[?:?]
at jdk.internal.reflect.GeneratedMethodAccessor212.invoke(Unknown Source) ~[?:?]
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
at org.openhab.core.internal.common.AbstractInvocationHandler.invokeDirect(AbstractInvocationHandler.java:147) ~[?:?]
at org.openhab.core.internal.common.InvocationHandlerSync.invoke(InvocationHandlerSync.java:59) ~[?:?]
at jdk.proxy8760.$Proxy8928.handleCommand(Unknown Source) ~[?:?]
at org.openhab.core.thing.internal.profiles.ProfileCallbackImpl.handleCommand(ProfileCallbackImpl.java:85) ~[?:?]
at org.openhab.core.thing.internal.profiles.SystemDefaultProfile.onCommandFromItem(SystemDefaultProfile.java:48) ~[?:?]
at jdk.internal.reflect.GeneratedMethodAccessor268.invoke(Unknown Source) ~[?:?]
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
at org.openhab.core.internal.common.AbstractInvocationHandler.invokeDirect(AbstractInvocationHandler.java:147) ~[?:?]
at org.openhab.core.internal.common.Invocation.call(Invocation.java:52) ~[?:?]
at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: org.openhab.binding.icloud.internal.ICloudApiResponseException: Request https://p138-fmipweb.icloud.com:443/fmipservice/client/web/playSound failed with 500.
at org.openhab.binding.icloud.internal.ICloudSession.request(ICloudSession.java:148) ~[?:?]
at org.openhab.binding.icloud.internal.ICloudSession.post(ICloudSession.java:98) ~[?:?]
at org.openhab.binding.icloud.internal.FindMyIPhoneServiceManager.playSound(FindMyIPhoneServiceManager.java:77) ~[?:?]
at org.openhab.binding.icloud.internal.handler.ICloudAccountBridgeHandler.lambda$5(ICloudAccountBridgeHandler.java:294) ~[?:?]
at org.openhab.binding.icloud.internal.handler.ICloudAccountBridgeHandler.callApiWithRetryAndExceptionHandling(ICloudAccountBridgeHandler.java:185) ~[?:?]
... 19 more
Environment
The text was updated successfully, but these errors were encountered: