[icloud] Use device.Id instead of device.DiscoveryId to fix playsound #16846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
lolodomo
added
bug
|
@openhab/add-ons-maintainers : any specialist of this binding to confirm that the functional change makes sense ? Not sure that the PR was properly signed. |
kaikreuzer
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
I'm not a specialist either, but as the feature is anyhow broken, it can only get better and I trust @maihacke that he properly tested it. Thanks!
The sign-off looks alright, no idea why the DCO check didn't report a status.
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 16, 2024
…#16846) Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
psmedley
added a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 16, 2024
…penhab#16846)" This reverts commit 5e2efda.
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…#16846) Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…#16846) Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…#16846) Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
…#16846) Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use device.Id instead of device.DiscoveryId to fix playsound
Should fix #15333