Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VeSync] Add "Change mode to auto" for Air Purifier Core 300S #16456

Closed
icsAT opened this issue Feb 24, 2024 · 4 comments · Fixed by #17842
Closed

[VeSync] Add "Change mode to auto" for Air Purifier Core 300S #16456

icsAT opened this issue Feb 24, 2024 · 4 comments · Fixed by #17842
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@icsAT
Copy link

icsAT commented Feb 24, 2024

I just got an Levoit Air Purifier Core 300S. And I am Using openHAB 4.1.1.

When I try to set fanMode to "auto" using openHAB with the VeSync-Binding I receive:
Fan mode command for "auto" is not valid in the (Core200S/Core300S) API possible options manual,sleep
The openHAB Documentation says the same, so the error makes sense. Works as designed.

If I use the VeSync App I am able to set the fanMode to "auto" and the value of the channel in openHAB becomes "auto", too.

Therefore I think there should be a possibility to set "fanMode" to "auto" for the Core 300S through the API and it would be great if someone could add this to the binding.

@icsAT icsAT added the enhancement An enhancement or new feature for an existing add-on label Feb 24, 2024
@dag81
Copy link
Contributor

dag81 commented Mar 3, 2024

I'll have a look when I can and compare to the latest PyVeSync revision. It was ported directly from that pyton lib, so it maybe at that point in time either no support existed, if its documented that way - that would have been the mappings originally ported over. It may be no one has reverse engineered the lib for PyVeSync for the auto functionality, that could be another reason in which case the command is unknown for what to send. I'll check as soon as I can @icsAT, just wrapping up a different binding at the moment first.

dag81 added a commit to dag81/openhab-addons that referenced this issue Dec 3, 2024
[vesync] Issue openhab#16456 Core300S auto mode

Signed-off-by: David Goodyear <david.goodyear@gmail.com>
@dag81
Copy link
Contributor

dag81 commented Dec 4, 2024

Hi @icsAT,

Sorry it took a really long time to get back. I compared the spec's and can see fan speeds 1...4 are now listed as valid for that device, and fan modes auto, manual, sleep.

I've just raised a PR with the changes, could you possibly check with this build the fan modes now work as you expect please, and possibly the fan speed's 1..4 as well please, given the new spec details.

Many thanks - and big apologies for not having the time until now to look at this.

David

Download link to a build I've dumped into a new repo for test builds - built against the code in this PR.

I believe this could work on 4.2 or 4.3 builds, from testing other builds for a big change set that went in, to simplify updates for issues like this if they arose, and make the binding more consistent for discovery of devices.

@icsAT
Copy link
Author

icsAT commented Dec 5, 2024

Hey @dag81,

no need to apologize. I know the value of time and I have developement projects myself, where I am not able to step foreward, because of time issues and prioritization.

I am on Stable 4.2.3 now.

As far, that I can tell from a short test, it is possible to set the 'auto' fanMode on my Core 300S now.

Thanks a lot.

Setting fan speed between 1 and 3 (C300S only has 3 levels) is also possible, as it was before. (For additional Information see #16457)

Greetings

icsAT

@dag81
Copy link
Contributor

dag81 commented Dec 5, 2024

Hey @dag81,

no need to apologize. I know the value of time and I have developement projects myself, where I am not able to step foreward, because of time issues and prioritization.

I am on Stable 4.2.3 now.

As far, that I can tell from a short test, it is possible to set the 'auto' fanMode on my Core 300S now.

Thanks a lot.

Setting fan speed between 1 and 3 (C300S only has 3 levels) is also possible, as it was before. (For additional Information see #16457)

Greetings

icsAT

I replied on the wrong thread, thanks for confirming. Let clean up the change to just the mode options, the pyvesync code didn't align to the manuals I was reading earlier. That clarifies thank you! :)

@lsiepel lsiepel linked a pull request Dec 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants