[vesync] Add auto-mode to core 300S devices #17842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[vesync] Core 300S Updates Signed-off-by: David Goodyear <david.goodyear@gmail.com>
[vesync] Cleanup Signed-off-by: David Goodyear <david.goodyear@gmail.com>
[vesync] Remove fan speed adjust Signed-off-by: David Goodyear <david.goodyear@gmail.com>
lsiepel
added
the
enhancement
lsiepel
changed the title
|
Thank you for the quick merge @lsiepel! 👍 |
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Dec 16, 2024
* [vesync] Core 300S Updates Signed-off-by: David Goodyear <david.goodyear@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[vesync] Core 300S Updates
This updates the device profile for the core 300S. This adds the auto mode to the fan modes for its profile. It looks like since the initial ports the modes specified for the device have been updated.
This change adds the auto mode as a valid payload for the protocol to allow for this device.
This relates to OpenHab issue: [#16456] (#16456).
The changes have been confirmed as working as expected.