Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace gnu.io dependency of add-ons with serial transport #7573

Open
18 of 22 tasks
wborn opened this issue May 8, 2020 · 16 comments
Open
18 of 22 tasks

Replace gnu.io dependency of add-ons with serial transport #7573

wborn opened this issue May 8, 2020 · 16 comments
Labels
help wanted

Comments

@wborn
Copy link
Member

wborn commented May 8, 2020 •
edited
Loading

There are still add-ons which depend on gnu.io for their serial communications. By using the serial transport we can switch between serial implementations (rxtx, javacomm) without having to change any add-on code. It also allows for using RFC2217 ports.

These bundles still depend on gnu.io:
@wborn wborn pinned this issue May 8, 2020
@wborn wborn mentioned this issue May 8, 2020
Merged
@lolodomo
Copy link
Contributor

lolodomo commented May 9, 2020

The rotelra1x binding is supposed to be removed in OH 3.0 as it was replaced by the rotel binding. We kept it in 2.5 to let the time to users to move to the new binding.

@wborn
Copy link
Member Author

wborn commented May 9, 2020

Great! I've updated the list so we won't spend any time on migrating that one. 👍

@wborn wborn mentioned this issue May 9, 2020
Closed
wborn added a commit to wborn/openhab-addons that referenced this issue May 10, 2020
@wborn
[pioneeravr] Use serial transport
5acd441 
Related to openhab#7573

Signed-off-by: Wouter Born <github@maindrain.net>
This was referenced May 10, 2020
Merged
Merged
kaikreuzer pushed a commit that referenced this issue May 10, 2020
@wborn
[pioneeravr] Use serial transport (#7588)
34549a0 
Related to #7573

Signed-off-by: Wouter Born <github@maindrain.net>
gnlpfjh pushed a commit to gnlpfjh/openhab-addons that referenced this issue May 11, 2020
@wborn @gnlpfjh
[pioneeravr] Use serial transport (openhab#7588)
3ea28c9 
Related to openhab#7573

Signed-off-by: Wouter Born <github@maindrain.net>
@gnlpfjh
Copy link
Contributor

gnlpfjh commented May 11, 2020

With #6447 phc binding uses serial transport.

@wborn
Copy link
Member Author

wborn commented May 11, 2020

Very nice! I even see you updated the POM for the import that was added in #7589. 👍

@bobadair bobadair mentioned this issue May 12, 2020
Merged
wborn added a commit to wborn/openhab-addons that referenced this issue May 12, 2020
@wborn
[digiplex] Use serial transport
3951b40 
Related to openhab#7573

Also removes the gnu.io import from the lutron POM, related to openhab#7609

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-addons that referenced this issue May 12, 2020
@wborn
[digiplex] Use serial transport
dc93e2c 
Related to openhab#7573

Also removes the gnu.io import from the lutron POM, related to openhab#7609

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this issue May 12, 2020
Merged
wborn added a commit to wborn/openhab-addons that referenced this issue May 12, 2020
@wborn
[digiplex] Use serial transport
affe530 
Related to openhab#7573

Also removes the IT100BridgeDiscovery which sends messages to all available serial ports.
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the serial ports in UIs from all available serial devices.

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-addons that referenced this issue May 12, 2020
@wborn
[digiplex] Use serial transport
aae8511 
Related to openhab#7573

Also removes the IT100BridgeDiscovery which sends messages to all available serial ports.
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the serial ports in UIs from all available serial devices.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this issue May 12, 2020
Merged
wborn added a commit to wborn/openhab-addons that referenced this issue May 12, 2020
@wborn
[dscalarm] Use serial transport
b82ae6c 
Related to openhab#7573

Also removes the IT100BridgeDiscovery which sends messages to all available serial ports.
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the serial ports in UIs from all available serial devices.

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-addons that referenced this issue May 12, 2020
@wborn
[elerotransmitterstick] Use serial transport
0662257 
Related to openhab#7573

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this issue May 12, 2020
Merged
wborn added a commit to wborn/openhab-addons that referenced this issue May 12, 2020
@wborn
[jeelink] Use serial transport
f61231f 
Related to openhab#7573

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this issue May 12, 2020
Merged
cpmeister pushed a commit that referenced this issue May 12, 2020
@wborn
[digiplex] Use serial transport (#7617)
b469399 
Related to #7573

Also removes the gnu.io import from the lutron POM, related to #7609

Signed-off-by: Wouter Born <github@maindrain.net>
cpmeister pushed a commit that referenced this issue May 12, 2020
@wborn
[dscalarm] Use serial transport (#7618)
a7dc2c2 
Related to #7573

Also removes the IT100BridgeDiscovery which sends messages to all available serial ports.
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the serial ports in UIs from all available serial devices.

Signed-off-by: Wouter Born <github@maindrain.net>
cpmeister pushed a commit that referenced this issue May 12, 2020
@wborn
[elerotransmitterstick] Use serial transport (#7619)
8ba9f60 
Related to #7573

Signed-off-by: Wouter Born <github@maindrain.net>
cpmeister pushed a commit that referenced this issue May 13, 2020
@wborn
[jeelink] Use serial transport (#7620)
194c471 
* [jeelink] Use serial transport

Related to #7573
* Pass around SerialPortIdentifier instead of SerialPortManager

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-addons that referenced this issue May 14, 2020
@wborn
[lgtvserial] Use serial transport
3a2e41e 
Related to openhab#7573

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this issue Jun 26, 2022
Merged
@kaikreuzer
Copy link
Member

@wborn Do you have any good idea wrt @holgerfriedrich's question on how to best proceed for KNX?

@holgerfriedrich
Copy link
Member

holgerfriedrich commented Oct 2, 2022 •
edited
Loading

@kaikreuzer Calimero 2.5.1 release branch has just been created a few hours ago; the code for serial port has changed..... let's see....

@wborn
Copy link
Member Author

wborn commented Oct 3, 2022

Yes it looks like you can now create your own SerialCom implementation and use that instead of the calimero-rxtx dependency. It will create/use a SerialCom instance based on the class name in META-INF/services/tuwien.auto.calimero.serial.spi.SerialCom, see: calimero-project/calimero-rxtx@1e74d81

@jsjames jsjames removed a link to a pull request Oct 4, 2022
[pentair] 7836-pentair binding improvements #7837
Closed
@jsjames jsjames linked a pull request Oct 4, 2022 that will close this issue
[pentair] Many enhancements since original commit, including #13485
Merged
holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this issue Dec 12, 2022
@holgerfriedrich
[knx] Use serial transport
410a24a 
Related to openhab#7573

Replace gnu.io by serial transport in binding code.
Transitive dependency on gnu.io still given by using calimero-rxtx.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@lsiepel lsiepel removed a link to a pull request Dec 23, 2022
[pentair] Many enhancements since original commit, including #13485
Merged
@lsiepel
Copy link
Contributor

lsiepel commented Dec 23, 2022

Work for the Pentair binding is on the way as @jsjames filed a PR for it: #13485

holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this issue Dec 23, 2022
@holgerfriedrich
[knx] Use serial transport
3d222b2 
Related to openhab#7573

Replace gnu.io by serial transport in binding code.
Transitive dependency on gnu.io still given by using calimero-rxtx.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich
Copy link
Member

holgerfriedrich commented Dec 23, 2022 •
edited
Loading

@wborn I created our own SerialCom implementation. In principle this seems to work, but there is a problem once the framework reloads the KNX plugin. ServiceLoader does not find the implementation anymore (or I have not yet found a way to properly push it), so I need to restart openHAB to properly reload.
If you have any suggestion, please comment in #14051.

holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this issue Dec 24, 2022
@holgerfriedrich
[knx] Use serial transport
350db26 
Related to openhab#7573

Replace gnu.io by serial transport in binding code.
Transitive dependency on gnu.io still given by using calimero-rxtx.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this issue Dec 26, 2022
@holgerfriedrich
[knx] Loadable class interface for serial communication
d5b378b 
Use the new SPI interface of Calimero 2.5.1 to provide serial
communication services to base library. Removes dependency on
gnu.io and calimero-rxtx.

Related to openhab#7573

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/usb-port-conflict-zigbee2mqtt-and-modbus/143448/8

holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this issue Feb 19, 2023
@holgerfriedrich
[knx] Use serial transport
990792c 
Related to openhab#7573

Replace gnu.io by serial transport in binding code.
Transitive dependency on gnu.io still given by using calimero-rxtx.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this issue Feb 19, 2023
@holgerfriedrich
[knx] Loadable class interface for serial communication
7752770 
Use the new SPI interface of Calimero 2.5.1 to provide serial
communication services to base library. Removes dependency on
gnu.io and calimero-rxtx.

Related to openhab#7573

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
This was referenced Mar 17, 2023
Closed
Open
@wborn wborn mentioned this issue May 31, 2023
Merged
This was referenced Aug 27, 2023
Open
Open
wborn added a commit to wborn/openhab-addons that referenced this issue Nov 25, 2023
@wborn
Add SAT warning when jSerialComm, PureJavaComm imports are used
581873a 
Add-ons should use the OH serial transport and not their own serial communication libraries.

Related to openhab#7573

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this issue Nov 25, 2023
Merged
jlaur pushed a commit that referenced this issue Nov 25, 2023
@wborn
Add SAT warning when jSerialComm, PureJavaComm imports are used (#15952)
1c8ce7c 
Add-ons should use the OH serial transport and not their own serial communication libraries.

Related to #7573

Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Nov 26, 2023
@wborn @andrewfg
Add SAT warning when jSerialComm, PureJavaComm imports are used (open…
846ab71 
…hab#15952)

Add-ons should use the OH serial transport and not their own serial communication libraries.

Related to openhab#7573

Signed-off-by: Wouter Born <github@maindrain.net>
This was referenced Nov 29, 2023
Closed
Open
@mvalla mvalla mentioned this issue Feb 5, 2024
Merged
@mvalla
Copy link
Contributor

mvalla commented Feb 5, 2024

For [openwebnet] just sbmitted a new PR that makes the binding independent from gnu.io.
See #16376.

austvik pushed a commit to austvik/openhab-addons that referenced this issue Mar 27, 2024
@wborn @austvik
Add SAT warning when jSerialComm, PureJavaComm imports are used (open…
1d026c0 
…hab#15952)

Add-ons should use the OH serial transport and not their own serial communication libraries.

Related to openhab#7573

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@bodiroga @holgerfriedrich @kaikreuzer @openhab-bot @lolodomo @gnlpfjh @wborn @mvalla @lsiepel