[jeelink] Use serial transport #7620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to openhab#7573 Signed-off-by: Wouter Born <github@maindrain.net>
22 tasks
cpmeister
requested changes
May 12, 2020
Comment on lines
73
to
77
| SerialPortIdentifier portIdentifier = serialPortManager.getIdentifier(port); | ||
| if (portIdentifier == null) { | ||
| notifyAbort("Port not found: " + port); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Is it possible to move this logic into JeeLinkHandler's initialize method so you can put the thing offline with a config error? You should be able to pass around the SerialPortIdentifier instance instead of the SerialPortManager instance.
There was a problem hiding this comment.
After revisiting the code it looks like it is possible. The static method was only used by the handler so that saves another level of passing stuff around. :-)
Signed-off-by: Wouter Born <github@maindrain.net>
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
* [jeelink] Use serial transport Related to openhab#7573 * Pass around SerialPortIdentifier instead of SerialPortManager Signed-off-by: Wouter Born <github@maindrain.net>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
* [jeelink] Use serial transport Related to openhab#7573 * Pass around SerialPortIdentifier instead of SerialPortManager Signed-off-by: Wouter Born <github@maindrain.net>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
* [jeelink] Use serial transport Related to openhab#7573 * Pass around SerialPortIdentifier instead of SerialPortManager Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [jeelink] Use serial transport Related to openhab#7573 * Pass around SerialPortIdentifier instead of SerialPortManager Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [jeelink] Use serial transport Related to openhab#7573 * Pass around SerialPortIdentifier instead of SerialPortManager Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [jeelink] Use serial transport Related to openhab#7573 * Pass around SerialPortIdentifier instead of SerialPortManager Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [jeelink] Use serial transport Related to openhab#7573 * Pass around SerialPortIdentifier instead of SerialPortManager Signed-off-by: Wouter Born <github@maindrain.net>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* [jeelink] Use serial transport Related to openhab#7573 * Pass around SerialPortIdentifier instead of SerialPortManager Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* [jeelink] Use serial transport Related to openhab#7573 * Pass around SerialPortIdentifier instead of SerialPortManager Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7573