-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gree] the Gree binding should allow for setting the swingUpDown setting to values 7-11 #8330
Labels
enhancement
An enhancement or new feature for an existing add-on
Comments
taboneclayton
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Aug 23, 2020
@fwolter, @markus7017 would you like me to implement a fix for this issue? |
sure, one thing is the validation, but the values are also mapped to textual channel values, please check both aspects I already noticed this, bit nobody reported this issue and if I remember correctly it was the same way in the code I took over |
markus7017
added a commit
to markus7017/openhab-addons
that referenced
this issue
Sep 15, 2020
Signed-off-by: Markus Michels <markus7017@gmail.com>
Hilbrand
pushed a commit
that referenced
this issue
Sep 15, 2020
* Adding retries for status pool and api request * README updated * Implements #8330: Swing Up/Down values 0-11 * Missing text resources added for V-SwingUpDown 7-11 Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017
added a commit
to markus7017/openhab-addons
that referenced
this issue
Sep 19, 2020
* Adding retries for status pool and api request * README updated * Implements openhab#8330: Swing Up/Down values 0-11 * Missing text resources added for V-SwingUpDown 7-11 Signed-off-by: Markus Michels <markus7017@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this issue
Oct 8, 2020
* Adding retries for status pool and api request * README updated * Implements openhab#8330: Swing Up/Down values 0-11 * Missing text resources added for V-SwingUpDown 7-11 Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As per documentation on the gree-remote project, Gree AC devices should support modes 7, 8, 9, 10, 11 for the
SwUpDn
field. These values map to partial swings as defined below:In the Gree openHAB binding this is mapped to the
swingUpDown
channel. The method GreeAirDevice#setDeviceSwingUpDown includes a comment specifying that values between 0 and 11 should be allowed. However the validation code only allows values between 0 and 6.This is quite an easy fix and I could apply the fix myself by wanted to open an issue first to make sure that this would be a wanted fix/improvement.
The text was updated successfully, but these errors were encountered: