Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gree] Minor improvements #8472

Merged
merged 5 commits into from
Sep 15, 2020
Merged

[gree] Minor improvements #8472

merged 5 commits into from
Sep 15, 2020

Conversation

markus7017
Copy link
Contributor

@markus7017 markus7017 commented Sep 15, 2020 •
edited
Loading

This PR adds some improvements

  • Improved timeout handling on temporary networks issues
  • currentTemperature is updated with NaN when no value is available (device returns -40)
  • channel swingUpDown now accepts values 0-11

@markus7017
Adding retries for status pool and api request
0b27b16 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
README updated
1305e1f 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 added the enhancement An enhancement or new feature for an existing add-on label Sep 15, 2020
@markus7017 markus7017 added this to the 2.5.9 milestone Sep 15, 2020
@markus7017 markus7017 self-assigned this Sep 15, 2020
This was linked to issues Sep 15, 2020
[gree] Improved timout/packet lost handling #8457
Closed
[gree] Not all GREE models support currentTemperature #8452
Closed
@TravisBuddy
Copy link

TravisBuddy commented Sep 15, 2020 •
edited
Loading

Travis tests were successful

Hey @markus7017,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@markus7017
Implements openhab#8330: Swing Up/Down values 0-11
d30d347 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 changed the title [gree] Improved timeout handling on temporary networks issues [gree] Minor improvements Sep 15, 2020
@markus7017 markus7017 linked an issue Sep 15, 2020 that may be closed by this pull request
[gree] the Gree binding should allow for setting the swingUpDown setting to values 7-11 #8330
Closed
Hilbrand
Hilbrand reviewed Sep 15, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments.

bundles/org.openhab.binding.gree/README.md Outdated Show resolved Hide resolved
...penhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/handler/GreeHandler.java Show resolved Hide resolved
...penhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/handler/GreeHandler.java Outdated Show resolved Hide resolved
@markus7017
Missing text resources added for V-SwingUpDown 7-11
2a87599 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
Copy link
Contributor Author

@Hilbrand done

@Hilbrand
Copy link
Member

Don't forget to push the changes.

@markus7017
review changes
faff853 
Signed-off-by: Markus Michels <markus7017@gmail.com>
Hilbrand
Hilbrand approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markus7017
Copy link
Contributor Author

Hi @fwolter, could you do the 2nd review?

@Hilbrand
Copy link
Member

Not directly needed to have a second review on enhancements. I was just waiting for the build.

@Hilbrand Hilbrand merged commit 2758ab4 into openhab:2.5.x Sep 15, 2020
@markus7017 markus7017 deleted the gree_snapshot branch September 15, 2020 20:59
@markus7017
Copy link
Contributor Author

Thanks @Hilbrand , worked super fast

markus7017 added a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@markus7017
[gree] Minor improvements (openhab#8472)
abfaccf 
* Adding retries for status pool and api request
* README updated
* Implements openhab#8330: Swing Up/Down values 0-11
* Missing text resources added for V-SwingUpDown 7-11

Signed-off-by: Markus Michels <markus7017@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
@markus7017 @andrewfg
[gree] Minor improvements (openhab#8472)
9d10990 
* Adding retries for status pool and api request
* README updated
* Implements openhab#8330: Swing Up/Down values 0-11
* Missing text resources added for V-SwingUpDown 7-11

Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

@fwolter fwolter Awaiting requested review from fwolter

Assignees

@markus7017 markus7017

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.9
3 participants
@markus7017 @TravisBuddy @Hilbrand