Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[epsonprojector] Always set ready=true on disconnect and improve documentation #10079

Merged
merged 2 commits into from
Feb 7, 2021
Merged

[epsonprojector] Always set ready=true on disconnect and improve documentation #10079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2e77d8
Always set ready on disconnect and improve documentation
mlobstein Feb 6, 2021
19c220a
improve documentation
mlobstein Feb 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bundles/org.openhab.binding.epsonprojector/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Epson Projector Binding

This binding is compatible with Epson projectors that support the ESC/VP21 protocol over the built-in ethernet port, serial port or USB to serial adapter.
If your projector does not have a built-in ethernet port, you can connect to your projector's serial port via a TCP connection using a serial over IP device or by using`ser2net`.
This binding is compatible with Epson projectors that support the ESC/VP21 protocol over the built-in network (ethernet or Wi-Fi) port, serial port or USB to serial adapter.
If your projector does not have built-in networking, you can connect to your projector's serial port via a TCP connection using a serial over IP device or by using`ser2net`.

## Supported Things

Expand All @@ -27,7 +27,7 @@ The `projector-serial` thing has the following configuration parameters:
The `projector-tcp` thing has the following configuration parameters:

- _host_: IP address for the projector or serial over IP device
- _port_: Port for the projector or serial over IP device; default 3629 for projectors with built-in ethernet connector
- _port_: Port for the projector or serial over IP device; default 3629 for projectors with built-in ethernet connector or Wi-Fi
- _pollingInterval_: Polling interval in seconds to update channel states | 5-60 seconds; default 10 seconds

Some notes:
Expand Down
2 changes: 1 addition & 1 deletion ...ector/src/main/java/org/openhab/binding/epsonprojector/internal/EpsonProjectorDevice.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,11 +206,11 @@ public void connect() throws EpsonProjectorException {
public void disconnect() throws EpsonProjectorException {
connection.disconnect();
connected = false;
ready = true;
ScheduledFuture<?> timeoutJob = this.timeoutJob;
if (timeoutJob != null) {
timeoutJob.cancel(true);
this.timeoutJob = null;
ready = true;
}
}

Expand Down