Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epsonprojector] Always set ready=true on disconnect and improve documentation #10079

Merged
merged 2 commits into from
Feb 7, 2021

Conversation

mlobstein
Copy link
Contributor

Implement the review change from #9770 to always set ready=true on disconnect. Also improved the README to mention projectors with built-in Wi-Fi.

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister added the bug An unexpected problem or unintended behavior of an add-on label Feb 7, 2021
@cpmeister cpmeister merged commit 10b9b56 into openhab:main Feb 7, 2021
@cpmeister cpmeister added this to the 3.1 milestone Feb 7, 2021
@mlobstein mlobstein deleted the epson_readyFlag_fix branch February 7, 2021 02:40
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…mentation (openhab#10079)

* Always set ready on disconnect and improve documentation
* improve documentation

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…mentation (openhab#10079)

* Always set ready on disconnect and improve documentation
* improve documentation

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…mentation (openhab#10079)

* Always set ready on disconnect and improve documentation
* improve documentation

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants