Skip to content

Commit

Permalink
[epsonprojector] Always set ready=true on disconnect and improve docu…
Browse files Browse the repository at this point in the history
…mentation (openhab#10079)

* Always set ready on disconnect and improve documentation
* improve documentation

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
  • Loading branch information
mlobstein authored and themillhousegroup committed May 10, 2021
1 parent 62bf8cd commit e46d9fa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions bundles/org.openhab.binding.epsonprojector/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Epson Projector Binding

This binding is compatible with Epson projectors that support the ESC/VP21 protocol over the built-in ethernet port, serial port or USB to serial adapter.
If your projector does not have a built-in ethernet port, you can connect to your projector's serial port via a TCP connection using a serial over IP device or by using`ser2net`.
This binding is compatible with Epson projectors that support the ESC/VP21 protocol over the built-in network (ethernet or Wi-Fi) port, serial port or USB to serial adapter.
If your projector does not have built-in networking, you can connect to your projector's serial port via a TCP connection using a serial over IP device or by using`ser2net`.

## Supported Things

Expand All @@ -27,7 +27,7 @@ The `projector-serial` thing has the following configuration parameters:
The `projector-tcp` thing has the following configuration parameters:

- _host_: IP address for the projector or serial over IP device
- _port_: Port for the projector or serial over IP device; default 3629 for projectors with built-in ethernet connector
- _port_: Port for the projector or serial over IP device; default 3629 for projectors with built-in ethernet connector or Wi-Fi
- _pollingInterval_: Polling interval in seconds to update channel states | 5-60 seconds; default 10 seconds

Some notes:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,11 +206,11 @@ public void connect() throws EpsonProjectorException {
public void disconnect() throws EpsonProjectorException {
connection.disconnect();
connected = false;
ready = true;
ScheduledFuture<?> timeoutJob = this.timeoutJob;
if (timeoutJob != null) {
timeoutJob.cancel(true);
this.timeoutJob = null;
ready = true;
}
}

Expand Down

0 comments on commit e46d9fa

Please sign in to comment.