[enocean] Improved device discovery and added SMACK capability (#10156) #10157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruggy83
added
the
enhancement
…hab#10156) * Added SMACK teach in * Teached in devices can be teach out on a repeated teach in * Improved detection of RPS devices, device types can be better distinguished now * Bugfixes for discovery fallback to GenericThings * Responses to message requests are send automatically now, no need for linking SEND_COMMAND channel Fixes openhab#10156 Signed-off-by: Daniel Weber <uni@fruggy.de>
fruggy83
force-pushed
the
issue10156_DeviceDiscoverySMACK
branch
from
f5f4e8d
to
68a5fdf
Compare
fwolter
requested changes
Feb 18, 2021
...ding.enocean/src/main/java/org/openhab/binding/enocean/internal/EnOceanBindingConstants.java
Show resolved
Hide resolved
...inding.enocean/src/main/java/org/openhab/binding/enocean/internal/EnOceanHandlerFactory.java
Show resolved
Hide resolved
...g.enocean/src/main/java/org/openhab/binding/enocean/internal/config/EnOceanBridgeConfig.java
Outdated
Show resolved
Hide resolved
.../main/java/org/openhab/binding/enocean/internal/discovery/EnOceanDeviceDiscoveryService.java
Outdated
Show resolved
Hide resolved
...cean/src/main/java/org/openhab/binding/enocean/internal/handler/EnOceanBaseThingHandler.java
Outdated
Show resolved
Hide resolved
Comment on lines
416
to
418
| logger.debug("Exception during activating smack teach in: {}", e.getMessage()); | ||
| updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, | ||
| "Smack packet could not be send"); |
There was a problem hiding this comment.
The log message could be removed, as the status update is already logged by the framework. You could include the exception's message in the status detail message.
The state change originated by updateStatus() is logged to events.log. Including the status detail message.
Same for below.
There was a problem hiding this comment.
I am not really sure what you mean with status detail message. I hope my change is ok now. I changed this and other occurences. Thanks for the hint 👍
...inding.enocean/src/main/java/org/openhab/binding/enocean/internal/messages/EventMessage.java
Outdated
Show resolved
Hide resolved
...n/java/org/openhab/binding/enocean/internal/messages/Responses/RDLearnedClientsResponse.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.enocean/src/main/resources/OH-INF/thing/bridge.xml
Outdated
Show resolved
Hide resolved
…ab#10156) * Code improvements after CR Fixes openhab#10156 Signed-off-by: Daniel Weber <uni@fruggy.de>
|
Hi Fabian @fwolter, thanks a lot for your review hints 👍 I hope you are fine with my improvements. Have a nice weekend. |
fwolter
approved these changes
Feb 20, 2021
There was a problem hiding this comment.
LGTM
Actually all newly added loggings to info should be debug or trace, but I see that lowering the severity would make it inconsistent to the existing code, so I'll merge it anyway.
info should be used for example when a new OSGi component started. There are almost no use cases where info should be used in bindings.
Would be awesome if you could file a follow-up PR to adjust all the info log levels!
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…hab#10157) * Added SMACK teach in * Teached in devices can be teach out on a repeated teach in * Improved detection of RPS devices, device types can be better distinguished now * Bugfixes for discovery fallback to GenericThings * Responses to message requests are send automatically now, no need for linking SEND_COMMAND channel Fixes openhab#10156 Signed-off-by: Daniel Weber <uni@fruggy.de> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…hab#10157) * Added SMACK teach in * Teached in devices can be teach out on a repeated teach in * Improved detection of RPS devices, device types can be better distinguished now * Bugfixes for discovery fallback to GenericThings * Responses to message requests are send automatically now, no need for linking SEND_COMMAND channel Fixes openhab#10156 Signed-off-by: Daniel Weber <uni@fruggy.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…hab#10157) * Added SMACK teach in * Teached in devices can be teach out on a repeated teach in * Improved detection of RPS devices, device types can be better distinguished now * Bugfixes for discovery fallback to GenericThings * Responses to message requests are send automatically now, no need for linking SEND_COMMAND channel Fixes openhab#10156 Signed-off-by: Daniel Weber <uni@fruggy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10156
Signed-off-by: Daniel Weber uni@fruggy.de