Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hue] Eliminate NPE in #9985 #10199

Merged
merged 11 commits into from
Feb 19, 2021
Merged

[hue] Eliminate NPE in #9985 #10199

merged 11 commits into from
Feb 19, 2021

Conversation

andrewfg
Copy link
Contributor

This eliminates an NPE inadvertently introduced #9985

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

@andrewfg
[hue] implement PR openhab#2144 in openhab.core
f6b0794 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[hue] add binding configuration parameter; return long
7d88bfd 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[hue] readme
f553546 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[hue] remove configurationPid hack
c08cab1 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[hue] use constructor injection
7082733 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[hue] binding.xml element attributes
710e156 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[hue] adopt reviewer suggestions
52a2334 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[hue] extra null check
0f1d889 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
Merge branch 'main' into hue-grace_period
ea12f94
@andrewfg
Merge branch 'main' into hue-grace_period
345e251 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg mentioned this pull request Feb 19, 2021
Merged
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/org-openhab-binding-hue-internal-discovery-huebridgediscoveryparticipant-threw-an-exception/117247/6

@andrewfg
Copy link
Contributor Author

@cweitkamp

@andrewfg andrewfg added the bug An unexpected problem or unintended behavior of an add-on label Feb 19, 2021
cweitkamp
cweitkamp approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit a9f440d into openhab:main Feb 19, 2021
@wborn wborn added this to the 3.1 milestone Mar 21, 2021
@andrewfg andrewfg deleted the hue-grace_period branch March 30, 2021 13:19
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@andrewfg @themillhousegroup
[hue] Eliminate NPE in openhab#9985 (openhab#10199)
649ac78 
* [hue] extra null check

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@andrewfg @thinkingstone
[hue] Eliminate NPE in openhab#9985 (openhab#10199)
e250c6b 
* [hue] extra null check

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@andrewfg
[hue] Eliminate NPE in openhab#9985 (openhab#10199)
e950100 
* [hue] extra null check

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewfg @openhab-bot @cweitkamp @wborn