-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openwebnet] add support for Thermoregulation (standalone thermostat and sensors) #10756
Conversation
@fwolter, do you think it's possibile to include this in 3.1M5 ? This is an important and long-awaited enhancement and surely users will need to test it before merging in the upcoming 3.1 (expected in June). If we skip merge of this PR to the June milestone, that would mean that it would be integrated in the official 3.1 without much testing by users. Of course we already tested it as much as possibile in our 2 setups, but having feedback from community would be impotant. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html
.
...ding.openwebnet/src/main/java/org/openhab/binding/openwebnet/OpenWebNetBindingConstants.java
Outdated
Show resolved
Hide resolved
...ding.openwebnet/src/main/java/org/openhab/binding/openwebnet/OpenWebNetBindingConstants.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetThermoregulationHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetThermoregulationHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetThermoregulationHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetThermoregulationHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetThermoregulationHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/BusTempSensor.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
@fwolter The jenkins build failed but not our fault. Should we do something? |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/bticino-openwebnet-new-openhab2-binding-ready-for-testing/43377/1538 |
… 0.5-shapshot) - [Thermo] new fanspeed channel to control fancoil speed (AUTO, VEL1/2/3) - [Thermo] support for mode (MANUAL, PROTECTION, OFF) and function (HEATING, COOLING, GENERIC) Signed-off-by: Conte Andrea <andrea@conte.com> Signed-off-by: Massimo Valla <mvcode00@gmail.com>
- add channel heatingValve - removed unused code and comments - replaced bridgeHandler.gateway.send() with this.send() --> better check for null Signed-off-by: Conte Andrea <andrea@conte.com> Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Conte Andrea <andrea@conte.com> Signed-off-by: Massimo Valla <mvcode00@gmail.com>
- added requestActuatorStatus() inside initialize() and bridgeStatusUpdate() Signed-off-by: Conte Andrea <andrea@conte.com> Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Conte Andrea <andrea@conte.com> Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Updated conditioning/heatingValve and actutor channels values to strings. Updated and cleaned-up README Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Conte Andrea <andrea@conte.com>
- added tests for WhereThermo and OwnId Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Conte Andrea <andrea@conte.com>
…orum hint to actuator/valve status Signed-off-by: Conte Andrea <andrea@conte.com>
Signed-off-by: Conte Andrea <andrea@conte.com>
…ed handleSetpoint and handleSetFanSpeed Signed-off-by: Massimo Valla <mvcode00@gmail.com>
64290b9
to
57a851a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you or @mvalla fix this SAT finding in a follow-up PR?
[WARNING] org.openhab.binding.openwebnet.handler.OpenWebNetEnergyHandler.java:[101]
For periodically executed jobs that do not require a fixed rate scheduleWithFixedDelay should be preferred over scheduleAtFixedRate.
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <andrea@conte.com> Signed-off-by: Massimo Valla <mvcode00@gmail.com> Co-authored-by: Massimo Valla <mvcode00@gmail.com>
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <andrea@conte.com> Signed-off-by: Massimo Valla <mvcode00@gmail.com> Co-authored-by: Massimo Valla <mvcode00@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <andrea@conte.com> Signed-off-by: Massimo Valla <mvcode00@gmail.com> Co-authored-by: Massimo Valla <mvcode00@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <andrea@conte.com> Signed-off-by: Massimo Valla <mvcode00@gmail.com> Co-authored-by: Massimo Valla <mvcode00@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <andrea@conte.com> Signed-off-by: Massimo Valla <mvcode00@gmail.com> Co-authored-by: Massimo Valla <mvcode00@gmail.com>
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <andrea@conte.com> Signed-off-by: Massimo Valla <mvcode00@gmail.com> Co-authored-by: Massimo Valla <mvcode00@gmail.com>
…and sensors) (openhab#10756) Signed-off-by: Conte Andrea <andrea@conte.com> Signed-off-by: Massimo Valla <mvcode00@gmail.com> Co-authored-by: Massimo Valla <mvcode00@gmail.com>
This enhancement restores support for Thermoregulation for standalone thermostat (bus_thermostat) and external wireless temperature sensors (bus_temp_sensor).
Fixes #10702
Fixes #8582