Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[airthings] Add support for Airthings Wave Gen 1 #11052

Merged
merged 17 commits into from
Jul 30, 2021
Merged

[airthings] Add support for Airthings Wave Gen 1 #11052

merged 17 commits into from
Jul 30, 2021

Conversation

dw-8
Copy link
Contributor

@dw-8 dw-8 commented Jul 23, 2021

Add support for Airthings Wave Gen 1

Signed-off-by: Davy Wong davy.wong.on+github@gmail.com

@dw-8 dw-8 requested a review from paulianttila as a code owner July 23, 2021 19:41
@dw-8 dw-8 force-pushed the add-airthings-wave-gen1-support-1 branch from 0e6aa86 to 425a31f Compare July 23, 2021 19:43
kaikreuzer
kaikreuzer requested changes Jul 24, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition!
Just some very small review comments before we can merge.

bundles/org.openhab.binding.bluetooth.airthings/src/main/resources/OH-INF/thing/airthings.xml Outdated
<bridge-type-ref id="roaming" />
<bridge-type-ref id="bluegiga" />
<bridge-type-ref id="bluez" />
</supported-bridge-type-refs><label>Airthings Wave Gen 1</label><description>Smart Radon Monitor</description><channels>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some line breaks seem to be missing here.
Please run a mvn spotless:apply.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the corrections.

...src/main/java/org/openhab/binding/bluetooth/airthings/internal/AirthingsWaveGen1Handler.java Outdated
switch (readSensor) {
case TEMPERATURE:
dblResult = intFromBytes(rawdata[0], rawdata[1]) / 100D;
logger.info("Parsed data 1: {}", String.format("[temperature=%.1f °C]", dblResult));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only use debug level for all those logs (here and below).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed all logging to debug level only, as requested.

@dw-8 dw-8 requested review from davidgraeff, marcelrv, paphko and a team as code owners July 25, 2021 05:31
@dw-8 dw-8 force-pushed the add-airthings-wave-gen1-support-1 branch 4 times, most recently from 71264c7 to 2c6a934 Compare July 25, 2021 06:11
dw-8 and others added 16 commits July 25, 2021 02:16
@dw-8
[airthings] Add support for Airthings Wave Gen 1
cfc395e 
[airthings] Add support for Airthings Wave Gen 1

[airthings] Add support for Airthings Wave Gen 1

[airthings] Add support for Airthings Wave Gen 1

[airthings] Add support for Airthings Wave Gen 1

[airthings] Add support for Airthings Wave Gen 1

Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@marcelrv @dw-8
[miio] Minor improvement documentation & deviceId update message (ope…
690e3fa 
…nhab#11046)

* [miio] Minor improvement documentation & message
* [miio] minor cleanup from sat
* miio] fix another minor datetimeformat SAT issue

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@siglp @dw-8
Update README.md (openhab#11045)
cd37f19 
Add binding for Hama IR100, Hama DIR3100 and Auna Connect CD

Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@cweitkamp @dw-8
Changed default color mode for color commands to XY (openhab#11036)
414c0e1 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@matchews @dw-8
[haywardomnilogic] Remove erroneous chlorinator code from filterhandl…
a1f9f61 
…er (openhab#11028)

* Removed erroneous chlorinator code from filterhandler

Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@lolodomo @dw-8
[homeassistant/homie] Standardize config URI (openhab#11021)
be408d2 
* [homeassistant/homie] Standardize config URI

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@nimric @dw-8
[jdbc] Select the proper schema when retrieving the item tables (open…
37af085 
…hab#11023)

Signed-off-by: Riccardo Nimser-Joseph <github@nimric.de>
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@dw-8
[airthings] Add support for Airthings Wave Gen 1
b3c4a46 
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@dw-8
[airthings] Add support for Airthings Wave Gen 1
f67b488 
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@dw-8
Revert "Merge branch 'openhab:main' into add-airthings-wave-gen1-supp…
58bd978 
…ort-1"

This reverts commit 0c637df, reversing
changes made to 425a31f.

Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@dw-8
[airthings] Add support for Airthings Wave Gen 1
c964514 
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@dw-8
Revert "[miio] Minor improvement documentation & deviceId update mess…
9ee7464 
…age (openhab#11046)"

This reverts commit a3a30ac.

Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@dw-8
Revert "Update README.md (openhab#11045)"
5a46e68 
This reverts commit 3c3c4a0.

Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@dw-8
Revert "[haywardomnilogic] Remove erroneous chlorinator code from fil…
30c5983 
…terhandler (openhab#11028)"

This reverts commit 607bfc1.

Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@dw-8
Revert "[homeassistant/homie] Standardize config URI (openhab#11021)"
ad35fc4 
This reverts commit ebbc17d.

Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@dw-8
Revert "[jdbc] Select the proper schema when retrieving the item tabl…
992d960 
…es (openhab#11023)"

This reverts commit 291d904.

Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@dw-8 dw-8 force-pushed the add-airthings-wave-gen1-support-1 branch from 5155245 to 992d960 Compare July 25, 2021 06:16
@dw-8
Revert "Changed default color mode for color commands to XY (openhab#…
7e63973 
…11036)"

This reverts commit 414c0e1.

Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
@dw-8 dw-8 force-pushed the add-airthings-wave-gen1-support-1 branch from 1ac48d0 to 7e63973 Compare July 25, 2021 06:33
@dw-8 dw-8 requested review from kaikreuzer and removed request for a team July 25, 2021 06:37
@dw-8
Copy link
Contributor Author

dw-8 commented Jul 25, 2021

Well, making those revisions to two files became very messy with a lot of extra commits...
I accidentally merged a bunch of other commits into my PR, which I tried to revert and then revert them again.
I think I cleaned it all up, but now I have 3 extra reviewers because of those other commits.

@dw-8
Copy link
Contributor Author

dw-8 commented Jul 28, 2021

@kaikreuzer Are you okay with the changes I made in address your requested changes?

kaikreuzer
kaikreuzer approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good to me, thank you!

@kaikreuzer kaikreuzer merged commit 12dc0c3 into openhab:main Jul 30, 2021
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature for an existing add-on label Jul 30, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Jul 30, 2021
@kaikreuzer kaikreuzer mentioned this pull request Jul 31, 2021
Merged
@kaikreuzer
Copy link
Member

FTR, the formatting was still not ok, I have created #11068 to fix it.

@kaikreuzer kaikreuzer mentioned this pull request Jul 31, 2021
Merged
@kaikreuzer
Copy link
Member

FTR, the SAT tests were failing as well 😢 . Fixed it with #11074.

frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@dw-8 @frederictobiasc
[airthings] Add support for Airthings Wave Gen 1 (openhab#11052)
d5303d9 
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@dw-8 @thinkingstone
[airthings] Add support for Airthings Wave Gen 1 (openhab#11052)
5f9d517 
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
@dw-8 @dschoepel
[airthings] Add support for Airthings Wave Gen 1 (openhab#11052)
0743daa 
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@dw-8
[airthings] Add support for Airthings Wave Gen 1 (openhab#11052)
362c0c1 
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@davidgraeff davidgraeff Awaiting requested review from davidgraeff

@marcelrv marcelrv Awaiting requested review from marcelrv

@paphko paphko Awaiting requested review from paphko

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
8 participants
@dw-8 @kaikreuzer @marcelrv @siglp @cweitkamp @matchews @lolodomo @nimric