-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xmppclient] Add send image throught HTTP #11247
Conversation
3b6f0f5
to
e428ca5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
oob has not been implemented yet in smack. It has been running ok on my local for now, so I would leave as is. Any suggestion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am just not enough expert in dependencies to understand if this is normal that a dependency is added in feature file but not in POM (bcprov).
I let another maintainer merge this PR as I am not sure about the dependencies stuff (bcprov). |
@wborn : can you have a look on this one? |
@fwolter : maybe you can have a quick look, at least to confirm that everything is as expected for the dependency? |
You should be able to set the scope to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency in general should be okay. I'm not aware of, that there's any provided method to upload files via HTTP.
...hab.binding.xmppclient/src/main/java/org/openhab/binding/xmppclient/internal/XMPPClient.java
Outdated
Show resolved
Hide resolved
...ing.xmppclient/src/main/java/org/openhab/binding/xmppclient/internal/action/XMPPActions.java
Outdated
Show resolved
Hide resolved
c427f3c
to
8db325e
Compare
Signed-off-by: Fabien Carrion <fabien@carrion.mx>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay to add a transitive dependency to features.xml, but not to the pom.xml. @openhab/add-ons-maintainers please correct me if I'm wrong.
@gkfabs Can you file another PR, setting the dependencies in the pom.xml to provided?
@fwolter Do you want me to set all the smack libs dependencies to provided or only the new one smack-experimental? |
Each dependency, which exists in features.xml. |
Signed-off-by: Fabien Carrion <fabien@carrion.mx>
Signed-off-by: Fabien Carrion <fabien@carrion.mx> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
Signed-off-by: Fabien Carrion <fabien@carrion.mx> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
Signed-off-by: Fabien Carrion <fabien@carrion.mx>
Signed-off-by: Fabien Carrion <fabien@carrion.mx>
When I have an alert on my phone, I would like to be able to see an image which comes from the corresponding camera. For example when I feed the fishs or when I am not at home, the security camera corresponding to the PIR.
At first I wanted to integrate the jingle file transfert. But I think it will take time to see it in Smack igniterealtime/Smack#489
This is why I did a small improvement using https://github.com/igniterealtime/Smack/tree/master/smack-experimental/src/main/java/org/jivesoftware/smackx/httpfileupload
But I am getting some problems to add a new library: smack-experimental.
Thanks