[xmppclient] Set dependencies in the pom.xml to provided #11418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one which exists in features.xml Signed-off-by: Fabien Carrion <fabien@carrion.mx>
|
Looks good! Did you test the JAR on your system, just to be sure not only the compilation works, but also the dependency resolution on the system? |
kaikreuzer
added
rebuild
|
I recompile openhab-xmppclient addons, regenerate an addon kar using openhab distro. And it works like a charm. |
fwolter
added
the
enhancement
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
…one which exists in features.xml (openhab#11418) Signed-off-by: Fabien Carrion <fabien@carrion.mx> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…one which exists in features.xml (openhab#11418) Signed-off-by: Fabien Carrion <fabien@carrion.mx> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…one which exists in features.xml (openhab#11418) Signed-off-by: Fabien Carrion <fabien@carrion.mx>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…one which exists in features.xml (openhab#11418) Signed-off-by: Fabien Carrion <fabien@carrion.mx>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked by @fwolter in #11247
I set all the dependencies in the pom.xml to provided for all the one which exists in features.xml, because it's okay to add a transitive dependency to features.xml, but not to the pom.xml