Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openwebnet] Reduced log messages during UPnP bridge discovery #11705

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

mvalla
Copy link
Contributor

@mvalla mvalla commented Dec 5, 2021

Closes #11701 by changing 2 log messages to DEBUG level.

@@ -226,7 +226,7 @@ private DeviceInfo(RemoteDevice device) {
}
}
}
logger.info("Found BTicino device: not a OpenWebNet gateway or is not supported (UDN={})", idString);
logger.info("Found BTicino device: not a OpenWebNet gateway or not supported (UDN={})", idString);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even this one could be rather DEBUG?
We should have the minimum of INFO logs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would find useful to tell the user via INFO message that the BTicino device that was found is NOT a gateway that can be used by this binding for integration. Therefore I would leave the level to INFO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let another maintainer decide.
@kaikreuzer ?

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla mvalla force-pushed the openwebnet-3.2-upnp-log branch from f66d03a to dda0833 Compare December 5, 2021 09:00
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openwebnet-bticino-openhab3/128305/9

@wborn wborn added the bug An unexpected problem or unintended behavior of an add-on label Dec 5, 2021
@lolodomo lolodomo added the cre Coordinated Review Effort label Dec 10, 2021
@lolodomo
Copy link
Contributor

@fwolter : please have a look, if this is ok for you to leave an INFO level log, you can merge.

@fwolter fwolter merged commit 67f7de1 into openhab:main Dec 12, 2021
@fwolter fwolter added this to the 3.2 milestone Dec 12, 2021
@wborn wborn changed the title [openwebnet] reduced log messages during UPnP bridge discovery [openwebnet] Reduced log messages during UPnP bridge discovery Dec 18, 2021
@mvalla mvalla deleted the openwebnet-3.2-upnp-log branch December 24, 2021 09:39
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
…ab#11705)

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
…ab#11705)

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…ab#11705)

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on cre Coordinated Review Effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openwebnet] reduce INFO log messages for upnp discovery
5 participants