Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openwebnet] Reduced log messages during UPnP bridge discovery #11705

Merged
merged 1 commit into from
Dec 12, 2021
Merged

[openwebnet] Reduced log messages during UPnP bridge discovery #11705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .../main/java/org/openhab/binding/openwebnet/internal/discovery/BusGatewayUpnpDiscovery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,10 @@ public Set<ThingTypeUID> getSupportedThingTypeUIDs() {

@Override
public @Nullable DiscoveryResult createResult(RemoteDevice device) {
logger.info("Found device {}", device.getType());
logger.debug("Found device {}", device.getType());
DeviceInfo devInfo = new DeviceInfo(device);
if (!devInfo.manufacturer.matches("<unknown>")) {
logger.info(" |- {} ({})", devInfo.modelName, devInfo.manufacturer);
logger.debug(" |- {} ({})", devInfo.modelName, devInfo.manufacturer);
}
ThingUID thingId = generateThingUID(devInfo);
if (thingId != null) {
Expand Down Expand Up @@ -226,7 +226,7 @@ public Set<ThingTypeUID> getSupportedThingTypeUIDs() {
}
}
}
logger.info("Found BTicino device: not a OpenWebNet gateway or is not supported (UDN={})", idString);
logger.info("Found BTicino device: not a OpenWebNet gateway or not supported (UDN={})", idString);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even this one could be rather DEBUG?
We should have the minimum of INFO logs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would find useful to tell the user via INFO message that the BTicino device that was found is NOT a gateway that can be used by this binding for integration. Therefore I would leave the level to INFO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let another maintainer decide.
@kaikreuzer ?

}
return null;
}
Expand Down