-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default translations for binding add-ons #11760
Conversation
This makes the texts used by these add-ons translatable with Crowdin. To keep the PR simple, it only adds default translations for add-ons which do not yet have any default translations properties file. We can do follow up PRs for adding missing key/values to add-ons that already have these files or to remove duplications. There are several add-ons in this PR that do have non-English translation files, so I'll upload those to Crowdin when the PR is merged. Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn : how do you want to proceed ? Noone will check in details all these files. We are confident in your tool and we just merge if it builds ? |
I would keep it open for a couple of hours so there is some time for comments like yours and then merge it today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! LGTM for the Alarm Decoder and Lutron bindings. Can you make the script available to sync new changes from the XML files to the default language properties files?
It's not a script but a Maven plug-in 😉, see openhab/openhab-core#2544. You can run it using:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for OmniLink
.../org.openhab.binding.monopriceaudio/src/main/resources/OH-INF/i18n/monopriceaudio.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.nuvo/src/main/resources/OH-INF/i18n/nuvo.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Wouter Born <github@maindrain.net>
bundles/org.openhab.binding.atlona/src/main/resources/OH-INF/i18n/atlona.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.autelis/src/main/resources/OH-INF/i18n/autelis.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.daikin/src/main/resources/OH-INF/i18n/daikin.properties
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/i18n/hydrawise.properties
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LIRC looks good
Signed-off-by: Wouter Born <github@maindrain.net>
Time to inject all that in Crowdin :) |
@wborn : do you have an easy way to rerun your command for the |
On the CLI you can do something like this with Bash at the repo root:
It reruns the plugin on all add-ons and then only adds the files in my commit to another commit... and then cleans all modified/untracked files in the workspace and undos the commit. |
* Add default translations for binding add-ons This makes the texts used by these add-ons translatable with Crowdin. To keep the PR simple, it only adds default translations for add-ons which do not yet have any default translations properties file. We can do follow up PRs for adding missing key/values to add-ons that already have these files or to remove duplications. There are several add-ons in this PR that do have non-English translation files, so I'll upload those to Crowdin when the PR is merged. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
* Add default translations for binding add-ons This makes the texts used by these add-ons translatable with Crowdin. To keep the PR simple, it only adds default translations for add-ons which do not yet have any default translations properties file. We can do follow up PRs for adding missing key/values to add-ons that already have these files or to remove duplications. There are several add-ons in this PR that do have non-English translation files, so I'll upload those to Crowdin when the PR is merged. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
* Add default translations for binding add-ons This makes the texts used by these add-ons translatable with Crowdin. To keep the PR simple, it only adds default translations for add-ons which do not yet have any default translations properties file. We can do follow up PRs for adding missing key/values to add-ons that already have these files or to remove duplications. There are several add-ons in this PR that do have non-English translation files, so I'll upload those to Crowdin when the PR is merged. Signed-off-by: Wouter Born <github@maindrain.net>
* Add default translations for binding add-ons This makes the texts used by these add-ons translatable with Crowdin. To keep the PR simple, it only adds default translations for add-ons which do not yet have any default translations properties file. We can do follow up PRs for adding missing key/values to add-ons that already have these files or to remove duplications. There are several add-ons in this PR that do have non-English translation files, so I'll upload those to Crowdin when the PR is merged. Signed-off-by: Wouter Born <github@maindrain.net>
* Add default translations for binding add-ons This makes the texts used by these add-ons translatable with Crowdin. To keep the PR simple, it only adds default translations for add-ons which do not yet have any default translations properties file. We can do follow up PRs for adding missing key/values to add-ons that already have these files or to remove duplications. There are several add-ons in this PR that do have non-English translation files, so I'll upload those to Crowdin when the PR is merged. Signed-off-by: Wouter Born <github@maindrain.net>
* Add default translations for binding add-ons This makes the texts used by these add-ons translatable with Crowdin. To keep the PR simple, it only adds default translations for add-ons which do not yet have any default translations properties file. We can do follow up PRs for adding missing key/values to add-ons that already have these files or to remove duplications. There are several add-ons in this PR that do have non-English translation files, so I'll upload those to Crowdin when the PR is merged. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
This makes the texts used by these add-ons translatable with Crowdin.
To keep the PR simple, it only adds default translations for add-ons which do not yet have any default translations properties file.
We can do follow up PRs for adding missing key/values to add-ons that already have these files or to remove duplications.
There are several add-ons in this PR that do have non-English translation files, so I'll upload those to Crowdin when the PR is merged.