Update default translations #15420

florian-h05 · 2023-08-13T13:56:26Z

@openhab/add-ons-maintainers While working on #15378, I noticed that there are many add-ons with out-dated default translations.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

itests/org.openhab.binding.nest.tests/src/main/resources/OH-INF/i18n/nest.properties

wborn · 2023-08-14T10:12:26Z

I noticed that there are many add-ons with out-dated default translations.

Previously the plug-in was only used to generate files for add-ons that did not have any at all (#11760).
It was still new back then and not all issues had been ironed out, so I didn't run it on everything like you did.
It seems to do a pretty good job now though. 🙂

florian-h05 · 2023-08-14T17:00:03Z

@lsiepel

Did you only regenerate the default translation from the xml files? Or did you alse check custom translations on other places in the binding that are not detected bij the i18n generation?

I only ran the i18n plugin, did not check anything manually.

The i18n plugin does not detect all placeholders.
This is removed, but used here: https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.binding.livisismarthome/src/main/java/org/openhab/binding/livisismarthome/internal/handler/LivisiBridgeHandler.java#L170

There are certainly more bindings that have similar issues.

Right, haven't thought about this yet. Probably it is better to close this PR and instead ask the binding maintainers from the code owners file to update their bindings? I don't have the time to check all placeholders that are removed ...

soenkekueper

LGTM deutschebahn

lsiepel · 2023-08-14T18:13:22Z

@lsiepel

Did you only regenerate the default translation from the xml files? Or did you alse check custom translations on other places in the binding that are not detected bij the i18n generation?

I only ran the i18n plugin, did not check anything manually.

The i18n plugin does not detect all placeholders.
This is removed, but used here: https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.binding.livisismarthome/src/main/java/org/openhab/binding/livisismarthome/internal/handler/LivisiBridgeHandler.java#L170
There are certainly more bindings that have similar issues.

Right, haven't thought about this yet. Probably it is better to close this PR and instead ask the binding maintainers from the code owners file to update their bindings? I don't have the time to check all placeholders that are removed ...

I have checked 80, might check the rest too. One might allways slip, but that can allways be fixed easily. Creating 147 separate PR's is also a huge effort and is no garantuee of similar issues. So i suggest to go forward with this, but i am not a maintainer :-)

gdolfen

LGTM for enigma2 binding

andrewfg · 2023-08-14T20:02:54Z

only ran the i18n plugin, did not check anything manually.

Perhaps do a search for @text/* ??

lsiepel

2nd pass: checked remaining 65 bindings :-/
Did not check each lines, just scanned them and i think there are some minor adjustements needed.

itests/org.openhab.binding.nest.tests/src/main/resources/OH-INF/i18n/nest.properties

...dergroundupdatereceiver/src/main/resources/OH-INF/i18n/wundergroundupdatereceiver.properties

bundles/org.openhab.binding.tacmi/src/main/resources/OH-INF/i18n/tacmi.properties

bundles/org.openhab.binding.snmp/src/main/resources/OH-INF/i18n/snmp.properties

lsiepel · 2023-08-14T20:09:51Z

bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/i18n/shelly.properties

@@ -1,590 +1,72 @@
-# add-on


@markus7017 is doing an extensive refactoring of this binding, maybe he can confirm that this is ok? Removing ~600 lines and only adding ~75 lines of translation.

In this case I will leave the shelly.properties unchanged and let @markus7017 manage the translations.

We are just finalizing the latest PR. Anything open from this PR?

@florian-h05 I always manage translations incl. using crowdin
There are still some strings in the XML like symbolic thing name, which I didn't move to the resource file. I think it doesn't make sense to have the same string in EN+DE, but of course I could do that.

I didn't got what's required on top, is there anything specific from this PR

As you always manage translations, I will leave those translations to you.
I guess I will close this PR now as it seems no one is willing to review it, so do your Shelly PR as you want to.

I think it doesn't make sense to have the same string in EN+DE, but of course I could do that.

Agreed. I haven’t checked these details when updating the translations, because doing that for all bindings would be very time-expensive job.

druciak · 2023-08-15T18:19:08Z

bundles/org.openhab.binding.satel/src/main/resources/OH-INF/i18n/satel.properties

+
+# thing types
+
+thing-type.satel.atd-100.label = ATD-100


Does it make sense to put device model symbol to translation file?

In this case it makes sense to leave because the descriptions should be translated IMHO.

- Addressed review. - I have read through all changes files and fixed every bug I noticed. - I decided to leave out persistence, because I have an extra PR for that. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

florian-h05

I have read through all changed files, addressed the reviews and fixed my own findings.

florian-h05 · 2023-08-17T13:44:51Z

bundles/org.openhab.binding.satel/src/main/resources/OH-INF/i18n/satel.properties

+
+# thing types
+
+thing-type.satel.atd-100.label = ATD-100


In this case it makes sense to leave because the descriptions should be translated IMHO.

florian-h05 · 2023-08-17T13:46:55Z

bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/i18n/shelly.properties

@@ -1,590 +1,72 @@
-# add-on


In this case I will leave the shelly.properties unchanged and let @markus7017 manage the translations.

florian-h05 · 2023-08-17T14:07:52Z

...es/org.openhab.binding.nzwateralerts/src/main/resources/OH-INF/i18n/nzwateralerts.properties

@@ -12,30 +12,6 @@ thing-type.nzwateralerts.wateralert.description = Water Alert Levels for New Zea

 thing-type.config.nzwateralerts.wateralert.location.label = Location
 thing-type.config.nzwateralerts.wateralert.location.description = The location to get the Water Alert level for.
-thing-type.config.nzwateralerts.wateralert.location.option.bewaterwise:whangarei:breambay = Bream Bay


FYI: I removed the locations here, no need to have them translated.

...rg.openhab.binding.livisismarthome/src/main/resources/OH-INF/i18n/livisismarthome.properties

florian-h05 · 2023-08-17T14:14:29Z

@lsiepel @openhab/add-ons-maintainers IMO this is ready now.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

druciak

Satel looks good.

lsiepel

LGTM, Thanks!

dalgwen · 2023-08-18T09:52:55Z

bundles/org.openhab.voice.mimictts/src/main/resources/OH-INF/i18n/mimictts.properties

+addon.mimictts.name = Mimic Text-to-Speech
+addon.mimictts.description = The Mimic Text-to-Speech (TTS) service uses the offline open source Text-to-Speech engine designed by Mycroft A.I.
+
+# add-on


Hello,
I think this second "# add-on" line is a typo ?

It is generated by the plugin, and also exists for other files like jsscripting.properties.

stefan-hoehn

LGTM for Nanoleaf

Wolfgang1966

LGTM for aWATTar and tacmi

weymann

mercedes & e3dc lgtm

Signed-off-by: Bernhard Bauer <bern77@gmail.com>

bern77

Thanks for your initiative!
I've added some additional translations to completely match the German version of the file.
Also, I believe the file has to be named differently.
(see my 2 commits)

Otherwise - LGTM 😊

ne0h

LGTM for KVV

lsiepel · 2023-08-24T20:22:20Z

Thanks for your initiative! I've added some additional translations to completely match the German version of the file. Also, I believe the file has to be named differently. (see my 2 commits)

Otherwise - LGTM 😊

Both of your commits, lack DCO.

Besides that, if the i18n plugin generates wrong filename for 'sub' bindings like Modbus and Bluetooth, shouldn't those bindings also be fixed?

Then i look ad at your other commit where you added some translations, i noticed that here the modbuis without subbinding name is missing: example:
channel-group-type.modbus.co2Control.label

Only difference is the binding name. This looks to be the same problem (wrong binding name) as with the file name, possibly a i18n plugin bug? Or am i mistaken?
Edit: i guess i'm wrong. Anyway, why didn't the i18n tool pick up these additional translations?

Unless this can be fixed easily, i suggest leaving the translations for those affected bindings out of this PR. Just to speed up merging this PR, as the number of bindings/files involved, this can get a merge conflict galore :-)

bern77 · 2023-08-25T12:38:44Z

Thanks for your initiative! I've added some additional translations to completely match the German version of the file. Also, I believe the file has to be named differently. (see my 2 commits)
Otherwise - LGTM 😊

Both of your commits, lack DCO.

I made the edits directly in GitHub. The graced me with the learning, into which of the two presented text boxes I should copy the DCO 🙄

Besides that, if the i18n plugin generates wrong filename for 'sub' bindings like Modbus and Bluetooth, shouldn't those bindings also be fixed?

Then i look ad at your other commit where you added some translations, i noticed that here the modbuis without subbinding name is missing: example: channel-group-type.modbus.co2Control.label

Only difference is the binding name. This looks to be the same problem (wrong binding name) as with the file name, possibly a i18n plugin bug? Or am i mistaken? Edit: i guess i'm wrong. Anyway, why didn't the i18n tool pick up these additional translations?

TBH I've never used the i18n plugin and created the translation files manually... so I'm not really sure where or how to tackle this.

Unless this can be fixed easily, i suggest leaving the translations for those affected bindings out of this PR. Just to speed up merging this PR, as the number of bindings/files involved, this can get a merge conflict galore :-)

I'm also fine with that and could simply add the translations in an own PR. No intention to make this more complex than necessary!

stefan-hoehn

Nanoleaf LGTM

marcelrv

thanks!
LGTM for miio

florian-h05 · 2023-11-13T18:52:52Z

Closing this PR as it I don’t expect it to get reviewed and it meanwhile might be outdated as well. In case someone agrees to review this, I can reopen.

lsiepel · 2023-11-13T19:02:44Z

Maybe it is better to seperate this to smaller chunks. Too bad for the efforts allready made.

Update default translations

0d238e3

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

wborn reviewed Aug 14, 2023

View reviewed changes

itests/org.openhab.binding.nest.tests/src/main/resources/OH-INF/i18n/nest.properties Outdated Show resolved Hide resolved

soenkekueper approved these changes Aug 14, 2023

View reviewed changes

gdolfen approved these changes Aug 14, 2023

View reviewed changes

lsiepel requested changes Aug 14, 2023

View reviewed changes

druciak reviewed Aug 15, 2023

View reviewed changes

Address review & Fix my own findings

976b322

- Addressed review. - I have read through all changes files and fixed every bug I noticed. - I decided to leave out persistence, because I have an extra PR for that. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

florian-h05 commented Aug 17, 2023

View reviewed changes

Spotless

f34989c

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

druciak approved these changes Aug 17, 2023

View reviewed changes

lsiepel approved these changes Aug 17, 2023

View reviewed changes

dalgwen reviewed Aug 18, 2023

View reviewed changes

stefan-hoehn approved these changes Aug 21, 2023

View reviewed changes

Wolfgang1966 approved these changes Aug 23, 2023

View reviewed changes

weymann approved these changes Aug 23, 2023

View reviewed changes

bern77 added 2 commits August 24, 2023 21:16

Update modbus.properties

caa1e13

Rename modbus.properties to helioseasycontrols.properties

a38e3d8

Signed-off-by: Bernhard Bauer <bern77@gmail.com>

bern77 approved these changes Aug 24, 2023

View reviewed changes

ne0h approved these changes Aug 24, 2023

View reviewed changes

stefan-hoehn approved these changes Oct 26, 2023

View reviewed changes

marcelrv approved these changes Oct 26, 2023

View reviewed changes

florian-h05 closed this Nov 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update default translations #15420

Update default translations #15420

florian-h05 commented Aug 13, 2023 •

edited

Loading

wborn commented Aug 14, 2023 •

edited

Loading

florian-h05 commented Aug 14, 2023

soenkekueper left a comment

lsiepel commented Aug 14, 2023

gdolfen left a comment

andrewfg commented Aug 14, 2023

lsiepel left a comment

lsiepel Aug 14, 2023

florian-h05 Aug 17, 2023

markus7017 Oct 22, 2023

markus7017 Nov 5, 2023

florian-h05 Nov 13, 2023

druciak Aug 15, 2023

florian-h05 Aug 17, 2023 •

edited

Loading

florian-h05 left a comment

florian-h05 Aug 17, 2023 •

edited

Loading

florian-h05 Aug 17, 2023

florian-h05 Aug 17, 2023

florian-h05 commented Aug 17, 2023

druciak left a comment

lsiepel left a comment

dalgwen Aug 18, 2023

florian-h05 Aug 19, 2023

stefan-hoehn left a comment

Wolfgang1966 left a comment

weymann left a comment

bern77 left a comment

ne0h left a comment

lsiepel commented Aug 24, 2023 •

edited

Loading

bern77 commented Aug 25, 2023

stefan-hoehn left a comment

marcelrv left a comment

florian-h05 commented Nov 13, 2023

lsiepel commented Nov 13, 2023

Update default translations #15420

Update default translations #15420

Conversation

florian-h05 commented Aug 13, 2023 • edited Loading

wborn commented Aug 14, 2023 • edited Loading

florian-h05 commented Aug 14, 2023

soenkekueper left a comment

Choose a reason for hiding this comment

lsiepel commented Aug 14, 2023

gdolfen left a comment

Choose a reason for hiding this comment

andrewfg commented Aug 14, 2023

lsiepel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

florian-h05 Aug 17, 2023 • edited Loading

Choose a reason for hiding this comment

florian-h05 left a comment

Choose a reason for hiding this comment

florian-h05 Aug 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

florian-h05 commented Aug 17, 2023

druciak left a comment

Choose a reason for hiding this comment

lsiepel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stefan-hoehn left a comment

Choose a reason for hiding this comment

Wolfgang1966 left a comment

Choose a reason for hiding this comment

weymann left a comment

Choose a reason for hiding this comment

bern77 left a comment

Choose a reason for hiding this comment

ne0h left a comment

Choose a reason for hiding this comment

lsiepel commented Aug 24, 2023 • edited Loading

bern77 commented Aug 25, 2023

stefan-hoehn left a comment

Choose a reason for hiding this comment

marcelrv left a comment

Choose a reason for hiding this comment

florian-h05 commented Nov 13, 2023

lsiepel commented Nov 13, 2023

florian-h05 commented Aug 13, 2023 •

edited

Loading

wborn commented Aug 14, 2023 •

edited

Loading

florian-h05 Aug 17, 2023 •

edited

Loading

florian-h05 Aug 17, 2023 •

edited

Loading

lsiepel commented Aug 24, 2023 •

edited

Loading