[tplinksmarthome] Added KL430 lightstrip support #12000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hilbrand
added
enhancement
Hilbrand
force-pushed
the
tplink-kl430
branch
from
1efc3a4 to
ca4f063
Compare
dustinsoftware
suggested changes
Feb 3, 2022
Hilbrand
force-pushed
the
tplink-kl430
branch
from
ca4f063 to
01e27d5
Compare
|
@Hilbrand : is it still work in progress ? |
|
I've remove the label work-in-progress as it's ready for review/merge. |
lolodomo
requested changes
Feb 7, 2022
...c/main/java/org/openhab/binding/tplinksmarthome/internal/handler/TPLinkSmartHomeActions.java
Outdated
Show resolved
Hide resolved
...ome/src/main/java/org/openhab/binding/tplinksmarthome/internal/handler/SmartHomeHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/openhab/binding/tplinksmarthome/internal/handler/TPLinkSmartHomeActions.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/openhab/binding/tplinksmarthome/internal/handler/TPLinkSmartHomeActions.java
Outdated
Show resolved
Hide resolved
...resources/org/openhab/binding/tplinksmarthome/internal/model/kl430_set_colortemperature.json
Outdated
Show resolved
Hide resolved
Closes openhab#8709 Additional: - Added action to send and receive json commands to a tplink device. This can be used for test purposes or to run commands not available through channels. Fixes: - Power channel of a bulb is defined as QuantityType in xml, therefor it should create the state using QuantityType - Retry getting values 5 times before setting the device offline. Reduced socket time out to 2 seconds as it normally should react quickly and if it times out it tries again. Also-by: Dustin Masters <ceo@dustinsoftware.com> Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Hilbrand
force-pushed
the
tplink-kl430
branch
from
fd7c251 to
5859a02
Compare
|
@Hilbrand : my intention was to merge. What did you change after my review ? Why a force push which I have no way to see what you changed since my last review ? |
|
@lolodomo I've only squashed to make sure it gets the commit message I preferred. You can see here there are no differences: https://github.com/hilbrand/openhab-addons/compare/fd7c251..5859a02 |
lolodomo
approved these changes
Feb 10, 2022
|
Just FYI by squashing and force pushing, my name on the contribution was lost, would have been cool to keep that on the contributor page. :( |
|
Sorry for that but unfortunately the squashing was not done by myself. |
|
@dustinsoftware that would have been inevitable. Even if I wouldn't have squashed it, it would have happened when @lolodomo would merge this pr. Because all pr's in this repository are squashed before merging. |
|
@Hilbrand : when squashing, we can keep the mention of several contributors, signed-off- by for the main author and another (sorry I do not remember the exact tag) for additional contributors. |
|
@lolodomo Yes adding the other contributors is required, with |
|
Ok, that is clearer now. |
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
Closes openhab#8709 Additional: - Added action to send and receive json commands to a tplink device. This can be used for test purposes or to run commands not available through channels. Fixes: - Power channel of a bulb is defined as QuantityType in xml, therefor it should create the state using QuantityType - Retry getting values 5 times before setting the device offline. Reduced socket time out to 2 seconds as it normally should react quickly and if it times out it tries again. Also-by: Dustin Masters <ceo@dustinsoftware.com> Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
Closes openhab#8709 Additional: - Added action to send and receive json commands to a tplink device. This can be used for test purposes or to run commands not available through channels. Fixes: - Power channel of a bulb is defined as QuantityType in xml, therefor it should create the state using QuantityType - Retry getting values 5 times before setting the device offline. Reduced socket time out to 2 seconds as it normally should react quickly and if it times out it tries again. Also-by: Dustin Masters <ceo@dustinsoftware.com> Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Closes openhab#8709 Additional: - Added action to send and receive json commands to a tplink device. This can be used for test purposes or to run commands not available through channels. Fixes: - Power channel of a bulb is defined as QuantityType in xml, therefor it should create the state using QuantityType - Retry getting values 5 times before setting the device offline. Reduced socket time out to 2 seconds as it normally should react quickly and if it times out it tries again. Also-by: Dustin Masters <ceo@dustinsoftware.com> Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
Closes openhab#8709 Additional: - Added action to send and receive json commands to a tplink device. This can be used for test purposes or to run commands not available through channels. Fixes: - Power channel of a bulb is defined as QuantityType in xml, therefor it should create the state using QuantityType - Retry getting values 5 times before setting the device offline. Reduced socket time out to 2 seconds as it normally should react quickly and if it times out it tries again. Also-by: Dustin Masters <ceo@dustinsoftware.com> Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
Closes openhab#8709 Additional: - Added action to send and receive json commands to a tplink device. This can be used for test purposes or to run commands not available through channels. Fixes: - Power channel of a bulb is defined as QuantityType in xml, therefor it should create the state using QuantityType - Retry getting values 5 times before setting the device offline. Reduced socket time out to 2 seconds as it normally should react quickly and if it times out it tries again. Also-by: Dustin Masters <ceo@dustinsoftware.com> Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8709
Additional:
Added action to send and receive json commands to a tplink device.
This can be used for test purposes or to run commands not available through channels.
Changed retry getting values 5 times before setting the device offline..Reduced socket time out to 2 seconds as it normally should react quickly and if it times out it tries again.