-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tplinksmarthome] KL400 support #12177
Conversation
…ice offline. Reduced socket time out to 2 seconds as it normally should react quickly and if it times out it tries again. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Added action to send and receive json commands to a tplink device. This can be used for test purposes or to run commands not available through channels. Closes openhab#8709 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
dd2cb99
to
688bcd8
Compare
Signed-off-by: Dustin Masters <ceo@dustinsoftware.com>
…ripColor Signed-off-by: Dustin Masters <ceo@dustinsoftware.com>
688bcd8
to
bb7fedc
Compare
Is there an order to respect for both of your PRs? |
No, I just wanted to get my KL400 lights working so I put both commits in this PR. :) I can split it into separate PRs if you prefer. |
Please coordinate with @Hilbrand . His PR is only draft! |
@dustinsoftware You can also create a PR against my branch. That way I can merge the changes in my pr and make the pr ready for review, and update the community marketplace. I had it draft to comply with the community marketplace guidelines and because my implementation was not tested (and I have no devices to test, so I was relying on the community to provide feedback, but didn't get any so far). |
Closing this pr. @dustinsoftware created a pr against my pr and that has been merged. @dustinsoftware Thanks for your fixes. |
This builds on the work of @Hilbrand, and fixes a bug with HSL commands ignoring the brightness.