[miio] Cloud login issues improvement #13715
Conversation
* Small change in debug loggin is login issues are expected * Additional trouble shooting steps in readme * Fix duplicate name in device list preventing readme maker running * Catch a json exception in readme maker close openhab#13611 close openhab#7459 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
...enhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/cloud/CloudLogin1DTO.java
Outdated
Show resolved
Hide resolved
| The most common problem is a wrong userId/password. Try to fix your userId/password. The login userId & password are entered in the binding config page. | ||
| If the problem persists you can try the following: | ||
|
|
||
| * Your ip might need to be validated/confirmed. Logon to https://account.xiaomi.com/ **from the ip of your openHAB server** with a browser. |
There was a problem hiding this comment.
I do not understand the second sentence.
There was a problem hiding this comment.
I rephrased it. Hope it is more clear this time
There was a problem hiding this comment.
@jlaur : do you understand what means "Logon to https://account.xiaomi.com/ from the ip of your openHAB server with a browser."?
There was a problem hiding this comment.
I'm not sure I understand it, but let me explain how I understand it: Xiaomi need a kind of verification that a specific IP address is assigned to the user claiming it. Or, more specifically, that the IP address is currently assigned (dynamically or statically) by the ISP to the users router. So I assume we are talking about the public IP address. In this case I would assume that a browser on any computer within the LAN behind the router (assuming only one public IP address) can be used to perform this "validation". So I don't understand it like I would need to install and try to run some browser on my openHABian installation running on a Raspberry Pi.
In other words, back to my intro: No, I'm not sure I understand it, I would need some more context, and I think it could be further rewritten after that.
There was a problem hiding this comment.
@jlaur I think your understanding is right. (at least in line with how I understand it myself and what i was intended to document as workaround)
For some time now we have occasionally folks where the cloud connection is not working and it remains unclear why not. As there are no really useful messages produced when it fails, these issues remained open.
For some it appears that they can overcome the matter by resetting their password, but for others this remains an issue and indeed no solution (that I can provide)
In the latest instance of such an issue #13611 it was found that it indeed seems some additional authentication step is required, to validate the ip. We still don't know when/why (as most users don't experience the issue) but it might be just the thing that is missing for these users.
Hence the PR is to document this special case in the readme / problem resolving section.
There was a problem hiding this comment.
The sentence I did not understand is still there, unchanged ; I am not sure the added screen capture is really helpful to understand it.
But ok, I will not insist more, let's assume the users will understand better than me what you mean.
There was a problem hiding this comment.
I did one more attempt to clarify it better, and trying to understand in which scenario's there might be issues.
The vast majority won't face this as their (external) ip is equal for both the OH server and their regular pc/browser ip.
There was a problem hiding this comment.
Ok thank you, I finally understood.
Maybe you could replace "connect from the ip of your openHAB server with a browser" by "connect with your browser while no VPN is enabled (to not hide your external IP address)". WDYT ?
And the screen capture is no more necessary. WDYT ?
There was a problem hiding this comment.
Maybe you could replace "connect from the ip of your openHAB server with a browser" by "connect with your browser while no VPN is enabled (to not hide your external IP address)". WDYT ?
I think that is the most likely usecase indeed, but I think the user creating the issue actually was hosting his OH server somewhere else (on a VPS), why I understood he made a bridge to that server and was running a browser from the ip of his hosting provider. (He was by running some vpn docker with port forwarding, he also could have used some SSH tunneling I think)
this is why I was emphasizing the ' from the ip of your openHAB server ' part...
Do you think it is more clear if i change it to something like "browse with the same external ip address as your openHAB server to...http etc"
The screenshot does not contribute much, no problem removing it...
There was a problem hiding this comment.
Do you think it is more clear if i change it to something like "browse with the same external ip address as your openHAB server to...http etc"
Yes, I believe
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com
* resolve merge conflict readme * minor reformatting by the automated json tooling. Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
...hab.binding.miio/src/main/java/org/openhab/binding/miio/internal/cloud/MiCloudConnector.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
kaikreuzer
changed the title
* [miio] cloud login issues improvement * Small change in debug loggin is login issues are expected * Additional trouble shooting steps in readme * Fix duplicate name in device list preventing readme maker running * Catch a json exception in readme maker close openhab#13611 close openhab#7459 * [miio] fix strange/foreign characters in readme Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
* [miio] cloud login issues improvement * Small change in debug loggin is login issues are expected * Additional trouble shooting steps in readme * Fix duplicate name in device list preventing readme maker running * Catch a json exception in readme maker close openhab#13611 close openhab#7459 * [miio] fix strange/foreign characters in readme Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] cloud login issues improvement * Small change in debug loggin is login issues are expected * Additional trouble shooting steps in readme * Fix duplicate name in device list preventing readme maker running * Catch a json exception in readme maker close openhab#13611 close openhab#7459 * [miio] fix strange/foreign characters in readme Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] cloud login issues improvement * Small change in debug loggin is login issues are expected * Additional trouble shooting steps in readme * Fix duplicate name in device list preventing readme maker running * Catch a json exception in readme maker close openhab#13611 close openhab#7459 * [miio] fix strange/foreign characters in readme Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] cloud login issues improvement * Small change in debug loggin is login issues are expected * Additional trouble shooting steps in readme * Fix duplicate name in device list preventing readme maker running * Catch a json exception in readme maker close openhab#13611 close openhab#7459 * [miio] fix strange/foreign characters in readme Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
close #13611
close #7459
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com