[miio] Fix dimming channels for several yeelights #13724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The majority of brightness channels were already converted to dimmer. This PR applies same to the 'other'brightness channels like nightlight and/or ambient close: openhab#9936 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
|
@marcelrv : is it a breaking change that should be mentioned through a note in the release notes? |
|
I'm not sure. |
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 22, 2022
The majority of brightness channels were already converted to dimmer. This PR applies same to the 'other'brightness channels like nightlight and/or ambient close: openhab#9936 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Dec 24, 2022
The majority of brightness channels were already converted to dimmer. This PR applies same to the 'other'brightness channels like nightlight and/or ambient close: openhab#9936 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
The majority of brightness channels were already converted to dimmer. This PR applies same to the 'other'brightness channels like nightlight and/or ambient close: openhab#9936 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
The majority of brightness channels were already converted to dimmer. This PR applies same to the 'other'brightness channels like nightlight and/or ambient close: openhab#9936 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
The majority of brightness channels were already converted to dimmer. This PR applies same to the 'other'brightness channels like nightlight and/or ambient close: openhab#9936 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 6, 2024
The majority of brightness channels were already converted to dimmer. This PR applies same to the 'other'brightness channels like nightlight and/or ambient close: openhab#9936 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of brightness channels were already converted to dimmer. This PR applies same to a few remaining brightness channels like nightlight and/or ambient
close: #9936
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com