Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[asuswrt] Initial contribution - new binding to get informations from Asus-Routers #13815

Merged
merged 13 commits into from
Jul 15, 2023
Merged

[asuswrt] Initial contribution - new binding to get informations from Asus-Routers #13815

merged 13 commits into from
Jul 15, 2023

Conversation

wildcs
Copy link
Contributor

@wildcs wildcs commented Dec 1, 2022

[ASUSWRT]

This is the initial contribution for my new binding to get informations from Asus-Routers.

It's possible to connect to routers from asus with AsusWRT or AsusWRT-Merlin OS an get some networking informations.
You can also monitor connected clients.

Readme and Download: here
Link to community thread: here

@wildcs wildcs requested a review from a team as a code owner December 1, 2022 16:22
@wildcs wildcs force-pushed the asuswrt branch 5 times, most recently from 75ba861 to c17f5ca Compare December 1, 2022 17:51
@jlaur jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Dec 1, 2022
wborn
wborn requested changes Dec 2, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR! I also have an ASUS router running Merlin and had plans to create a binding for it one day. So now I can help with testing/reviewing instead. 😉 Here are a few initial comments while quickly scrolling through the code:

bundles/pom.xml Outdated Show resolved Hide resolved
...ontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/src/main/feature/feature.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/i18n/asuswrt.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/binding/binding.xml Outdated Show resolved Hide resolved
@wborn
Copy link
Member

wborn commented Dec 2, 2022

You can probably fix the build by also adding the add-on to:

bom/openhab-addons/pom.xml

@wildcs wildcs force-pushed the asuswrt branch 2 times, most recently from 409b9ec to 18368a2 Compare December 2, 2022 19:34
@wborn
Copy link
Member

wborn commented Dec 2, 2022

Now that the build succeeds, the latest PR build is also available here:

https://openhab.jfrog.io/artifactory/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.asuswrt/3.4.0-SNAPSHOT/org.openhab.binding.asuswrt-3.4.0-SNAPSHOT.jar

You can bypass the annoying JFrog login screen by clicking the (hard to see) grey "X" in the top right corner... or just use wget to download it. 🙂

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/asuswrt-new-binding-to-get-infromations-from-asus-routers/141431/15

@wildcs wildcs requested a review from wborn December 2, 2022 22:05
Christian Wild and others added 7 commits March 13, 2023 19:16
@wildcs
[asuswrt] first working version
8f60bc3 
Signed-off-by: Christian Wild <christian@wild-cs.de>
@wildcs
[asuswrt] added client thing and client discovery
f9afbbd 
Signed-off-by: Christian Wild <christian@wild-cs.de>
@wildcs
[asuswrt] router cpu/memusage integrated. code optimizations
d1218b0 
Signed-off-by: Christian Wild <christian@wild-cs.de>
@wildcs
[asuswrt] enhanced errorhandling when router is offline
6634ead 
Signed-off-by: Christian Wild <christian@wild-cs.de>
@wildcs
[asuswrt] changed config class
9ec2e40 
Signed-off-by: Christian Wild <christian@wildclan.de>
@wildcs
[asuswrt] added interface thing
fe8ba9c 
* revised complete code

Signed-off-by: Christian Wild <christian@wildclan.de>
@wildcs
[asuswrt] included traffic monitoring
9053807 
Signed-off-by: Christian Wild <christian@wildclan.de>
@wildcs wildcs force-pushed the asuswrt branch 4 times, most recently from 438ec0d to b85a650 Compare March 13, 2023 18:56
@wildcs wildcs requested review from lsiepel and wborn and removed request for lsiepel March 13, 2023 20:26
lsiepel
lsiepel requested changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback, did not look at the .java files.

bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/i18n/tapocontrol.properties Outdated Show resolved Hide resolved
bundles/pom.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/i18n/asuswrt.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/addon/addon.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/README.md Outdated Show resolved Hide resolved
...swrt/src/main/java/org/openhab/binding/asuswrt/internal/constants/AsuswrtErrorConstants.java Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/addon/addon.xml Show resolved Hide resolved
@wildcs @wborn
[asuswrt] rebase to snapshot 4.0
a12b26a 
Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: Christian Wild <christian@wildclan.de>
@wildcs wildcs requested review from lsiepel and wborn and removed request for wborn and lsiepel March 15, 2023 10:09
@wildcs wildcs requested a review from lsiepel March 31, 2023 14:54
wborn
wborn requested changes Apr 16, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adressing the comments and rebasing the PR.
I finally found some time to give it a test and it works very well so far. 👍
I've also added a few more review comments.

bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/thing/client.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/i18n/asuswrt.properties Outdated Show resolved Hide resolved
...ng.asuswrt/src/main/java/org/openhab/binding/asuswrt/internal/structures/AsuswrtTraffic.java Outdated Show resolved Hide resolved
...binding.asuswrt/src/main/java/org/openhab/binding/asuswrt/internal/things/AsuswrtClient.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/thing/channels.xml Show resolved Hide resolved
...rt/src/main/java/org/openhab/binding/asuswrt/internal/constants/AsuswrtBindingConstants.java Outdated Show resolved Hide resolved
...rt/src/main/java/org/openhab/binding/asuswrt/internal/constants/AsuswrtBindingConstants.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/pom.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.asuswrt/README.md Outdated Show resolved Hide resolved
@wildcs @wborn
[asuswrt] Apply suggestions from code review
e438c61 
Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: Christian Wild <christian@wildclan.de>
@wildcs
Copy link
Contributor Author

wildcs commented Apr 16, 2023

Thanks for adressing the comments and rebasing the PR. I finally found some time to give it a test and it works very well so far. 👍 I've also added a few more review comments.

Thanks for reviewing 👍

@wildcs wildcs requested a review from wborn April 17, 2023 07:47
wborn
wborn requested changes Jul 9, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the rework! I found some more time to review this and added some more comments:

...ding.asuswrt/src/main/java/org/openhab/binding/asuswrt/internal/AsuswrtDiscoveryService.java Outdated Show resolved Hide resolved
...ding.asuswrt/src/main/java/org/openhab/binding/asuswrt/internal/AsuswrtDiscoveryService.java Outdated Show resolved Hide resolved
...ding.asuswrt/src/main/java/org/openhab/binding/asuswrt/internal/AsuswrtDiscoveryService.java Outdated Show resolved Hide resolved
...ding.asuswrt/src/main/java/org/openhab/binding/asuswrt/internal/AsuswrtDiscoveryService.java Outdated Show resolved Hide resolved
...ding.asuswrt/src/main/java/org/openhab/binding/asuswrt/internal/AsuswrtDiscoveryService.java Outdated Show resolved Hide resolved
...binding.asuswrt/src/main/java/org/openhab/binding/asuswrt/internal/helpers/AsuswrtUtils.java Outdated Show resolved Hide resolved
...binding.asuswrt/src/main/java/org/openhab/binding/asuswrt/internal/helpers/AsuswrtUtils.java Outdated Show resolved Hide resolved
...binding.asuswrt/src/main/java/org/openhab/binding/asuswrt/internal/helpers/AsuswrtUtils.java Outdated Show resolved Hide resolved
...binding.asuswrt/src/main/java/org/openhab/binding/asuswrt/internal/helpers/AsuswrtUtils.java Outdated Show resolved Hide resolved
...binding.asuswrt/src/main/java/org/openhab/binding/asuswrt/internal/helpers/AsuswrtUtils.java Outdated Show resolved Hide resolved
@wildcs @wborn
[asuswrt] Apply suggestions from code review
daf9900 
Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: Christian Wild <40909464+wildcs@users.noreply.github.com>
@wildcs @wborn
[asuswrt] Apply suggestions from code review
18411a4 
Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: Christian Wild <christian@wildclan.de>
@wildcs
Copy link
Contributor Author

wildcs commented Jul 10, 2023

Okay i think i changed almost of your requested changes.
Hope now it'll be clean. But can yout test the jar? Currently i got no Asus-Router anymore

wborn added 2 commits July 15, 2023 13:40
@wborn
Some more cleanup
a698c94 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Some more cleanup
1d2dfe7 
Signed-off-by: Wouter Born <github@maindrain.net>
wborn
wborn approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the nice binding! 👍 It still works after all the changes. I also did some more cleanups so it can be merged and be part of the OH4 M5 milestone. 🙂

@wborn wborn merged commit d2f4e05 into openhab:main Jul 15, 2023
@wborn wborn added this to the 4.0 milestone Jul 15, 2023
@wborn wborn mentioned this pull request Jul 16, 2023
Merged
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@wildcs @austvik
[asuswrt] Initial contribution (openhab#13815)
5bcecf3 
Signed-off-by: Christian Wild <christian@wildclan.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@lsiepel lsiepel Awaiting requested review from lsiepel

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wildcs @wborn @openhab-bot @lsiepel @jlaur