Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdpowerview] Remove deprecated scene channels #14033

Merged

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Dec 21, 2022

Related to #11637 after the introduction of scene groups and automations in addition to scenes. This required the use of channel groups for separating these three groups of dynamic channels.

Channel names before release 3.2:

  • Scene: 1

Channel names from release 3.2:

  • Scene: scenes#1
  • Scene Group: sceneGroups#1
  • Automation: automations#1

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Dec 21, 2022
@jlaur jlaur requested a review from a team December 21, 2022 20:40
@lsiepel
Copy link
Contributor

lsiepel commented Dec 24, 2022

https://github.com/openhab/openhab-distro/blob/00bc9270035c98a86b7c4bbc782273d4fab04a31/distributions/openhab/src/main/resources/bin/update.lst#L54

Breaking change was allready mentioned in 3.2.0 But this channel was still useable. Does it need another warning that it finally got removed?

@jlaur
Copy link
Contributor Author

jlaur commented Dec 24, 2022

Breaking change was allready mentioned in 3.2.0 But this channel was still useable. Does it need another warning that it finally got removed?

Yes, I plan to do that, just didn't get around to create the PR yet. Thanks for the reminder. :-)

@jlaur
Copy link
Contributor Author

jlaur commented Dec 24, 2022

Created openhab/openhab-distro#1449.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

@andrewfg : please have a look.

Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 436e7c3 into openhab:main Dec 27, 2022
@lolodomo lolodomo added this to the 4.0 milestone Dec 27, 2022
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur deleted the 11637-hdpowerview-remove-deprecated-channels branch May 24, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants