Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[danfossairunit] Remove deprecated channel 'manual_fan_speed' #14030

Merged
merged 1 commit into from
Dec 28, 2022
Merged

[danfossairunit] Remove deprecated channel 'manual_fan_speed' #14030

merged 1 commit into from
Dec 28, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Dec 21, 2022

@jlaur
Remove deprecated channel
58143ed 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Dec 21, 2022
@jlaur jlaur requested a review from pravussum as a code owner December 21, 2022 16:45
@jlaur jlaur changed the title [danfossairunit] Remove deprecated channel 'manual_fan_speed' [danfossairunit] Remove deprecated channel 'main#manual_fan_speed' Dec 21, 2022
@jlaur jlaur changed the title [danfossairunit] Remove deprecated channel 'main#manual_fan_speed' [danfossairunit] Remove deprecated channel 'manual_fan_speed' Dec 21, 2022
@jlaur jlaur requested a review from a team December 21, 2022 16:48
@lsiepel
Copy link
Contributor

lsiepel commented Dec 24, 2022

Does this need a mention in the breaking change notices ? A warning has been issued before. But because the channel remained available, we might need to show it again?
https://github.com/openhab/openhab-distro/blob/00bc9270035c98a86b7c4bbc782273d4fab04a31/distributions/openhab/src/main/resources/bin/update.lst#L50

Otherwise LGTM

@jlaur
Copy link
Contributor Author

jlaur commented Dec 24, 2022

Does this need a mention in the breaking change notices ? A warning has been issued before. But because the channel remained available, we might need to show it again?

Yes, I plan to do that, just didn't get around to create the PR yet. Thanks for the reminder. :-)

@jlaur jlaur mentioned this pull request Dec 24, 2022
Merged
@jlaur
Copy link
Contributor Author

jlaur commented Dec 24, 2022

Created openhab/openhab-distro#1449.

lolodomo
lolodomo approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

@pravussum : please have a look.

@jlaur
Copy link
Contributor Author

jlaur commented Dec 28, 2022

@lolodomo - I think we can take a cross-binding decision about which breaking changes we can accept for 4.0 in order to clean up the code. #14033 has been merged, and this one is analogue to that: In both cases channels were deprecated in 3.2, but still supported (with deprecation warnings in log). And also in both cases they were mentioned in the 3.2 upgrade notes. So it would be inconsistent to merge one, but not the other. If you agree, please merge. Otherwise let's find some common ground. 🙂

pravussum
pravussum approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@pravussum pravussum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 3a4a387 into openhab:main Dec 28, 2022
@lolodomo lolodomo added this to the 4.0 milestone Dec 28, 2022
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
@jlaur @borazslo
Remove deprecated channel (openhab#14030)
372c025 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur mentioned this pull request Feb 21, 2023
Merged
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@jlaur @nemerdaud
Remove deprecated channel (openhab#14030)
a7ef804 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur deleted the 10621-danfossairunit-remove-deprecated-channel branch March 10, 2023 14:31
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@jlaur @renescherer
Remove deprecated channel (openhab#14030)
bcebb7b 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@lolodomo lolodomo mentioned this pull request May 4, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@pravussum pravussum pravussum approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jlaur @lsiepel @lolodomo @pravussum