Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking if upgrade instructions were provided for all OH 4 PRs #14928

Closed
5 of 29 tasks
lolodomo opened this issue May 4, 2023 · 8 comments
Closed
5 of 29 tasks

Checking if upgrade instructions were provided for all OH 4 PRs #14928

lolodomo opened this issue May 4, 2023 · 8 comments
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@lolodomo
Copy link
Contributor

lolodomo commented May 4, 2023

As a mechanism was introduced in OH 4 to provide an automatic upgrade of managed things, I think it would make sense that this mechanism was used in all PRs merged in OH4. At the time I am writing this message, we have 515 PRs merged tagged with milestone 4.0.
I think we could at least do a quick control in all these PRs, that is check if a thing was updated in XML files and no upgrade instructions were provided.
I will then list the found PRs here.
Is there someone to help me doing these checks ? I plan to start from the oldest. So if someone would like to start from the most recent, this would help.

Of course, after these PRs are identified, this will require to add upgrade instructions.

Checked from PR 14896 (page 2)
To be checked: #14622 #14641

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label May 4, 2023
@lolodomo
Copy link
Contributor Author

lolodomo commented May 4, 2023

@J-N-K : is the feature enough clever to not add again a channel that would be already present because a user created his thing after the enhancement but before upgrade instructions were provided?
Is there a risk to provide upgrade instructions very late? I am thinking about users who installed milestones or snapshots.

@J-N-K
Copy link
Member

J-N-K commented May 4, 2023

No, but you can workaround that by using "update" instead of "add". Calling "add" when a channel already exists results in an exception, "remove" or "update" don't fail if the channel is not present.

@jlaur
Copy link
Contributor

jlaur commented May 4, 2023

@lolodomo:

@lolodomo lolodomo added enhancement An enhancement or new feature for an existing add-on and removed bug An unexpected problem or unintended behavior of an add-on labels May 12, 2023
@florian-h05
Copy link
Contributor

@lolodomo

  • evcc: Binding is using dynamic channels.

@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tibber-binding/67019/243

@lsiepel
Copy link
Contributor

lsiepel commented Jul 31, 2023

Willing to spare some time, but is this still relevant since 4.0 has allready been released?

@lolodomo
Copy link
Contributor Author

No, unfortunately, it is too late I believe.

@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/fine-offset-weather-station-binding-discussion/134167/228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

No branches or pull requests

6 participants