Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sleepiq] Add thing type update instructions #14460

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

mhilbush
Copy link
Contributor

@mhilbush mhilbush commented Feb 20, 2023

Add thing type instructions for updating thing with new channels.

This is a follow up to PR #14447, which added 4 new channels.

Signed-off-by: Mark Hilbush mark@hilbush.com

Signed-off-by: Mark Hilbush <mark@hilbush.com>
@mhilbush mhilbush requested a review from syphr42 as a code owner February 20, 2023 13:28
@mhilbush
Copy link
Contributor Author

@J-N-K Can you please have a look?

@mhilbush mhilbush added the enhancement An enhancement or new feature for an existing add-on label Feb 20, 2023
Signed-off-by: Mark Hilbush <mark@hilbush.com>
@jlaur jlaur added the regression Regression that happened during the development of a release. Not shown on final release notes. label Feb 20, 2023
Signed-off-by: Mark Hilbush <mark@hilbush.com>
@J-N-K J-N-K added awaiting other PR Depends on another PR and removed regression Regression that happened during the development of a release. Not shown on final release notes. labels Feb 20, 2023
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhilbush
Copy link
Contributor Author

mhilbush commented Mar 7, 2023

Now that openhab/openhab-core#3391 is merged, this should be ready for merge.

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit dba5550 into openhab:main Mar 7, 2023
@jlaur jlaur added this to the 4.0 milestone Mar 7, 2023
@mhilbush mhilbush deleted the sleepiq-update-instructions branch March 7, 2023 22:19
@jlaur jlaur removed the enhancement An enhancement or new feature for an existing add-on label Mar 10, 2023
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
* Add thing type update instructions
* Move thingTypeVersion to correct thing type
* Add groupIds to update instructions

Signed-off-by: Mark Hilbush <mark@hilbush.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
* Add thing type update instructions
* Move thingTypeVersion to correct thing type
* Add groupIds to update instructions

Signed-off-by: Mark Hilbush <mark@hilbush.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants