-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sleepiq] Add thing type update instructions #14460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Hilbush <mark@hilbush.com>
@J-N-K Can you please have a look? |
mhilbush
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Feb 20, 2023
J-N-K
reviewed
Feb 20, 2023
bundles/org.openhab.binding.sleepiq/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.sleepiq/src/main/resources/OH-INF/update/instructions.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Hilbush <mark@hilbush.com>
jlaur
added
the
regression
Regression that happened during the development of a release. Not shown on final release notes.
label
Feb 20, 2023
J-N-K
reviewed
Feb 20, 2023
bundles/org.openhab.binding.sleepiq/src/main/resources/OH-INF/update/instructions.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Hilbush <mark@hilbush.com>
J-N-K
added
awaiting other PR
Depends on another PR
and removed
regression
Regression that happened during the development of a release. Not shown on final release notes.
labels
Feb 20, 2023
J-N-K
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Now that openhab/openhab-core#3391 is merged, this should be ready for merge. |
jlaur
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jlaur
removed
the
enhancement
An enhancement or new feature for an existing add-on
label
Mar 10, 2023
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
* Add thing type update instructions * Move thingTypeVersion to correct thing type * Add groupIds to update instructions Signed-off-by: Mark Hilbush <mark@hilbush.com>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
* Add thing type update instructions * Move thingTypeVersion to correct thing type * Add groupIds to update instructions Signed-off-by: Mark Hilbush <mark@hilbush.com>
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add thing type instructions for updating thing with new channels.
This is a follow up to PR #14447, which added 4 new channels.
Signed-off-by: Mark Hilbush mark@hilbush.com